Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Tooltips #1510

Closed
wueestd opened this issue Jun 14, 2023 · 5 comments
Closed

Component: Tooltips #1510

wueestd opened this issue Jun 14, 2023 · 5 comments
Assignees
@wueestd
Labels
💚 APPROVED Review state 📦 components Related to the @swisspost/design-system-components package
Milestone
Design V1

Comments

@wueestd
Copy link

wueestd commented Jun 14, 2023 •
edited
Loading

Figma
https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=12772%3A61141&t=3YWu4pbxHkxbNAu6-1

https://www.figma.com/file/Uwug646a2z3s5Qwa2CZ4vV/POP-Design-System?type=design&node-id=579%3A9207&mode=design&t=sPZqfB953ntQ7LZs-1

Code
https://design-system.post.ch/#/ng-bootstrap-samples/popover
https://design-system.post.ch/#/ng-bootstrap-samples/tooltip

Doc
https://www.nngroup.com/articles/tooltip-guidelines/

Split into two components:

  • Tooltip (hover)
  • Popover (klick)
@wueestd wueestd self-assigned this Jun 14, 2023
@wueestd wueestd added the 📦 components Related to the @swisspost/design-system-components package label Jun 14, 2023
@wueestd
Copy link
Author

wueestd commented Jun 29, 2023 •
edited
Loading

  • check Color variants

@wueestd wueestd mentioned this issue Jul 26, 2023
Closed
@wueestd wueestd removed their assignment Sep 19, 2023
@wueestd wueestd changed the title Optimizie Tooltips Components: Tooltips Sep 19, 2023
@wueestd wueestd changed the title Components: Tooltips Component: Tooltips Sep 19, 2023
@wueestd wueestd added this to the Design V1 milestone Sep 20, 2023
@wueestd wueestd self-assigned this Sep 26, 2023
@wueestd wueestd assigned gfellerph and unassigned wueestd Oct 25, 2023
@wueestd
Copy link
Author

wueestd commented Oct 25, 2023

@gfellerph can you have a look at the figma page or assigne someone? https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=138%3A107&mode=design&t=2vWb18sQihdvXtx7-1

@gfellerph
Copy link
Member

@wueestd: points to discuss

  • Do we want to introduce a new size (5.5px)?
  • Dev: hide arrow/indicator in default implementation
  • Resolve other comments in figma

@gfellerph gfellerph assigned wueestd and unassigned gfellerph Nov 1, 2023
@wueestd
Copy link
Author

wueestd commented Nov 6, 2023

all comments resolved

@wueestd wueestd assigned gfellerph and unassigned wueestd Nov 6, 2023
@gfellerph gfellerph mentioned this issue Nov 7, 2023
Closed
@gfellerph
Copy link
Member

@wueestd I created a component entry on the tracker board https://github.com/swisspost/design-system-planning/issues/202 and added a dev ticket #2240

This issue can be closed.

@gfellerph gfellerph added the 💚 APPROVED Review state label Nov 7, 2023
@gfellerph gfellerph assigned wueestd and unassigned gfellerph Nov 7, 2023
@wueestd wueestd closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wueestd wueestd

Labels
💚 APPROVED Review state 📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Archived in project
Milestone
Design V1
Development

No branches or pull requests
2 participants
@gfellerph @wueestd