Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Modal / Dialog #1582

Closed
2 tasks
rouvenpost opened this issue Jun 29, 2023 · 7 comments
Closed
2 tasks

Component: Modal / Dialog #1582

rouvenpost opened this issue Jun 29, 2023 · 7 comments
Assignees
@gfellerph
Labels
🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem 🎨 figma
Milestone
Design V1

Comments

@rouvenpost
Copy link

rouvenpost commented Jun 29, 2023 •
edited by wueestd
Loading

  • Create Concept Dialog Modal

Proposal from @gfellerph

  • Modal: opens centered on the page, can have interactive elements, closes on outside click or X

  • Dialog: opens centered on the page, must have interactive elements, does not close on outside click or on X, only through cancel or OK buttons

  • create pattern

Figma
https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=16696%3A55910&mode=design&t=v21xVVGydMFRQiHB-1

old
https://www.figma.com/file/raFzhcFmx7rBk3zgg46kXc/post_portal_opp_layout_v58?type=design&node-id=0%3A17119&mode=design&t=KwoKUoB5Jttx8bky-1

Dev
https://design-system.post.ch/#/ng-bootstrap-samples/modal
https://design-system.post.ch/#/post-samples/notification-overlay

Doc
https://www.experience-hub.ch/document/2803#/organisms-module/dialog
@wueestd wueestd changed the title Dialog Modal Component: Modal Sep 19, 2023
@wueestd wueestd changed the title Component: Modal Component: Modal / Dialog Sep 19, 2023
@wueestd wueestd added this to the Design V1 milestone Sep 27, 2023
@kaloyanso kaloyanso self-assigned this Nov 24, 2023
@kaloyanso
Copy link

Hi @wueestd, can you have a look at the component and review when you have the chance? :)

@gfellerph gfellerph self-assigned this Dec 5, 2023
@wueestd wueestd removed their assignment Dec 6, 2023
@gfellerph
Copy link
Member

gfellerph commented Jan 8, 2024 •
edited by rouvenpost
Loading

@Cian77 assigning back to you due to the status in Figma. It seems some checks are still open

  • Check variants
  • Scrollbar needs space
  • Text replacement

@gfellerph gfellerph assigned Cian77 and unassigned Cian77, kaloyanso and gfellerph Jan 8, 2024
@Cian77 Cian77 removed their assignment Feb 1, 2024
@rouvenpost rouvenpost self-assigned this Feb 2, 2024
@rouvenpost
Copy link
Author

Design Ready for Review

@rouvenpost
Copy link
Author

I adjusted the Scrollbar position as suggested. @gfellerph @Cian77 can you check...

@rouvenpost
Copy link
Author

@Cian77 Can you have a look at it?

@rouvenpost
Copy link
Author

Addes Text replacment.
Added Scrollbar.

@rouvenpost rouvenpost assigned gfellerph and unassigned Cian77 Apr 11, 2024
@github-actions github-actions bot added the stale label Jul 11, 2024
@gfellerph gfellerph added the 🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem label Jul 15, 2024
@github-actions github-actions bot removed the stale label Jul 15, 2024
@gfellerph
Copy link
Member

Closing as done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfellerph gfellerph

Labels
🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem 🎨 figma
Projects
Design System Production Board
Status: 🚀 Done
Milestone
Design V1
Development

No branches or pull requests
5 participants
@gfellerph @wueestd @rouvenpost @Cian77 @kaloyanso