Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker: the code sample submits forms #1815

Closed
gfellerph opened this issue Aug 17, 2023 · 0 comments · Fixed by #1856
Closed

Datepicker: the code sample submits forms #1815

gfellerph opened this issue Aug 17, 2023 · 0 comments · Fixed by #1856
Assignees
@b1aserlu
Labels
🐞 bug Something isn't working 📦 demo Related to the @swisspost/design-system-demo package request
Milestone
Maintenance

Comments

@gfellerph
Copy link
Member

When directly integrating the datepicker like here: https://design-system.post.ch/#/ng-bootstrap-samples/datepicker, a click on the button immediately submits a form. We need to add type="button" to the datepicker icon.
@gfellerph gfellerph added 🐞 bug Something isn't working 📦 demo Related to the @swisspost/design-system-demo package pibs request labels Aug 17, 2023
@gfellerph gfellerph added this to the Maintenance milestone Aug 23, 2023
@b1aserlu b1aserlu self-assigned this Aug 23, 2023
@b1aserlu b1aserlu linked a pull request Aug 23, 2023 that will close this issue
fix(design-system-demo): prevents datepicker from submitting a form on click #1856
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b1aserlu b1aserlu

Labels
🐞 bug Something isn't working 📦 demo Related to the @swisspost/design-system-demo package request
Projects
Design System Production Board
Archived in project
Milestone
Maintenance
Development

Successfully merging a pull request may close this issue.

fix(design-system-demo): prevents datepicker from submitting a form on click swisspost/design-system
2 participants
@gfellerph @b1aserlu