Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): added a story for tables #1063

Merged
merged 8 commits into from
Feb 15, 2023
Merged

feat(docs): added a story for tables #1063

merged 8 commits into from
Feb 15, 2023

Conversation

gfellerph
Copy link
Member

No description provided.

@gfellerph gfellerph linked an issue Feb 2, 2023 that may be closed by this pull request
Story: Table #1061
Closed
@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023 •
edited

🦋 Changeset detected

Latest commit: b673bc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@swisspost/design-system-styles Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Feb 2, 2023 •
edited

Preview environment ready: https://preview-1063--swisspost-design-system-next.netlify.app
Preview environment ready: https://preview-1063--swisspost-web-frontend.netlify.app

oliverschuerch
oliverschuerch reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code output is probably not how we want it:
image

oliverschuerch
oliverschuerch reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such class align-middle on the tbody element:
image

oliverschuerch
oliverschuerch reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an other changeset to document the change in the styles pachage?

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gfellerph gfellerph changed the title fix(docs): added a story for tables feat(docs): added a story for tables Feb 15, 2023
@gfellerph gfellerph merged commit ee631f5 into main Feb 15, 2023
@gfellerph gfellerph deleted the 1061-story-table branch February 15, 2023 12:52
@github-actions github-actions bot mentioned this pull request Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch approved these changes

@alizedebray alizedebray Awaiting requested review from alizedebray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Story: Table
3 participants
@gfellerph @swisspost-bot @oliverschuerch