Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepper)!: Updated stepper markup #1232

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

gfellerph
Copy link
Member

Updated the markup for the stepper component in order to improve accessibility. Completed items now require the prefix "Complete" and incomplete steps are no longer links.

Updated the markup for the stepper component in order to improve accessibility. Completed items now require the prefix "Complete" and incomplete steps are no longer links.
@gfellerph gfellerph linked an issue Mar 8, 2023 that may be closed by this pull request
4 tasks
@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: 15fdd53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@swisspost/design-system-styles Major
@swisspost/design-system-demo Major
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Mar 8, 2023

Preview environment ready: https://preview-1232--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-1232--swisspost-design-system-next.netlify.app

@gfellerph gfellerph marked this pull request as ready for review March 8, 2023 10:51
The progress bar can be colored using bootstrap backgrounds. When changing the info color to light blue, there is no longer any bootstrap background with the brand yellow. Therefore we have to override the active progress color with yellow.
@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gfellerph gfellerph merged commit 7bb0acc into main Mar 8, 2023
@gfellerph gfellerph deleted the 108-accessibility-stepper branch March 8, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Stepper
3 participants