Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): clean up alert and toast styles #1350

Merged
merged 33 commits into from
Aug 14, 2023
Merged

fix(styles): clean up alert and toast styles #1350

merged 33 commits into from
Aug 14, 2023

Conversation

alizedebray
Copy link
Contributor

No description provided.

@alizedebray alizedebray linked an issue Apr 19, 2023 that may be closed by this pull request
Clean up alert/toast styles #352
Closed
@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023 •
edited

🦋 Changeset detected

Latest commit: 1dd35c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@swisspost/design-system-styles Minor
@swisspost/design-system-demo Minor
@swisspost/design-system-documentation Minor
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components Patch
@swisspost/design-system-documentation-v7 Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alizedebray alizedebray changed the title 352 clean up alerttoast styles fix(styles): clean up alert and toast styles Apr 19, 2023
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Apr 19, 2023 •
edited

Preview environment ready: https://preview-1350--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-1350--swisspost-design-system-next.netlify.app
Preview environment ready: https://preview-1350--swisspost-design-system-next-v7.netlify.app

@alizedebray alizedebray mentioned this pull request Apr 19, 2023
Closed
oliverschuerch
oliverschuerch requested changes Apr 28, 2023
View reviewed changes
.changeset/purple-sloths-bow.md Outdated Show resolved Hide resolved
.changeset/thirty-countries-agree.md Outdated Show resolved Hide resolved
packages/styles/src/variables/components/_alert.scss Outdated Show resolved Hide resolved
packages/styles/src/variables/components/_toasts.scss Outdated Show resolved Hide resolved
alizedebray and others added 11 commits May 2, 2023 15:56
@alizedebray @oliverschuerch
Update .changeset/thirty-countries-agree.md
4f3740e 
Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch>
@alizedebray @oliverschuerch
Update .changeset/purple-sloths-bow.md
bde6a9e 
Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch>
@alizedebray
feat(demo): move the alert color deprecation message
98bf026
@alizedebray
Merge remote-tracking branch 'origin/352-clean-up-alerttoast-styles' …
e5d1c2d 
…into 352-clean-up-alerttoast-styles
@alizedebray
feat(styles): rename alert-cookies to alert-gray
998972a
@alizedebray
feat(styles): refactor alert and toast variants
303010a
@alizedebray
feat(styles): remove deprecated alert and toast examples
2bc38c7
@alizedebray
feat(styles): rename ngx-toaster to ngx-toastr
0c8280e
@alizedebray
feat(styles): fix incorrect icon on toast
a23c839
@alizedebray
feat(styles): remove CSS custom properties for alerts and toasts
20ee73c
@alizedebray
feat(styles): remove CSS custom properties for close buttons
93fff75
oliverschuerch
oliverschuerch reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alizedebray The default story in the storybook alert component should have the new alert-gray variant as well.

@alizedebray alizedebray marked this pull request as draft June 5, 2023 12:16
@alizedebray alizedebray force-pushed the 352-clean-up-alerttoast-styles branch from c47c350 to 7e27337 Compare August 8, 2023 15:53
@alizedebray alizedebray marked this pull request as ready for review August 8, 2023 16:17
gfellerph
gfellerph requested changes Aug 9, 2023
View reviewed changes
.changeset/purple-sloths-bow.md Show resolved Hide resolved
.changeset/clever-kangaroos-switch.md Outdated Show resolved Hide resolved
.changeset/thirty-countries-agree.md Outdated Show resolved Hide resolved
packages/styles/src/components/alert.scss Show resolved Hide resolved
alizedebray and others added 2 commits August 9, 2023 14:16
@alizedebray @gfellerph
Update .changeset/purple-sloths-bow.md
4489a4c 
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
@alizedebray @gfellerph
Update .changeset/thirty-countries-agree.md
12863a1 
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
@alizedebray @gfellerph
Update .changeset/clever-kangaroos-switch.md
1dd35c6 
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alizedebray alizedebray merged commit 0211f6f into main Aug 14, 2023
11 checks passed
@alizedebray alizedebray deleted the 352-clean-up-alerttoast-styles branch August 14, 2023 06:50
@github-actions github-actions bot mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph approved these changes

@oliverschuerch oliverschuerch oliverschuerch approved these changes

@imagoiq imagoiq Awaiting requested review from imagoiq

Assignees

@alizedebray alizedebray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up alert/toast styles
4 participants
@alizedebray @swisspost-bot @gfellerph @oliverschuerch