fix(styles): Safari display issue with floating labels #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A rendering issue in Safari clipped text input in a floating label input field where the floating label intersected with the current value of the input. Even having a transparent background, the input was invisible below the floating label. Setting the height of the floating label correctly fixes the rendering issue because now the label does no longer cover the value.
🦋 Changeset detectedLatest commit: bc759fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview environment ready: https://preview-1461--swisspost-web-frontend.netlify.app |
Bootstrap 5.3 introduced a new background color for floating labels, causing the value to be hidden in our use case (not a safari rendering issue). https://blog.getbootstrap.com/2023/05/30/bootstrap-5-3-0/#:~:text=Updated%20the%20styling%20of%20floating%20labels%20when%20%E2%80%9Cfloated%E2%80%9D%20to%20include%20a%20background%2Dcolor%20to%20help%20with%20multiple%20lines%20of%20text%20in%20textareas.%20This%20also%20fixes%20the%20colors%20when%20form%20elements%20are%20disabled%20in%20floating%20forms.
|
Kudos, SonarCloud Quality Gate passed!
|
alizedebray
approved these changes
Jun 6, 2023
|
Tested on Browser Stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rendering issue in Safari clipped text input in a floating label input field where the floating label intersected with the current value of the input. Even having a transparent background, the input was invisible below the floating label. Setting the height of the floating label correctly fixes the rendering issue because now the label does no longer cover the value.