Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust default legend styles sizes #1512

Merged

Conversation

geekrumper
Copy link
Contributor

Using $font-size-18 for default legend styles

@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2023

🦋 Changeset detected

Latest commit: 567717a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jun 14, 2023

Preview environment ready: https://preview-1512--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-1512--swisspost-design-system-next.netlify.app

@geekrumper geekrumper force-pushed the 877-default-legend-styles-are-too-big branch from b0c9498 to c5d9b3b Compare June 14, 2023 12:23
@geekrumper geekrumper changed the title adjust default legend styles sizes #877 adjust default legend styles sizes Jun 14, 2023
@geekrumper geekrumper changed the title #877 adjust default legend styles sizes fix: adjust default legend styles sizes Jun 14, 2023
@geekrumper geekrumper force-pushed the 877-default-legend-styles-are-too-big branch from c5d9b3b to 984e109 Compare June 14, 2023 12:36
@gfellerph gfellerph added the open-source-day-june-2023 Tickets for people who'd like to get involved. label Jun 15, 2023
@gfellerph gfellerph linked an issue Jun 20, 2023 that may be closed by this pull request
@gfellerph
Copy link
Member

gfellerph commented Jun 20, 2023

@geekrumper, needed to do a slight adjustment to the definition. Setting a fixed value in the loop that defines font-size classes would have set every font-size class to the same value. Thank you for participating on the open source day!

@swisspost-bot
Copy link
Contributor

Preview environments are getting posted here, as soon as they are ready!

@swisspost-bot
Copy link
Contributor

Preview environment ready: https://preview-1512--swisspost-web-frontend.netlify.app

@swisspost-bot
Copy link
Contributor

Preview environments are getting posted here, as soon as they are ready!

@swisspost-bot
Copy link
Contributor

Preview environment ready: https://preview-1512--swisspost-design-system-next.netlify.app

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gfellerph gfellerph merged commit b440195 into swisspost:main Jun 27, 2023
8 checks passed
gfellerph added a commit that referenced this pull request Jun 29, 2023
* fix: adjust default legend styles sizes

* fix: use dedicated selector to set legend font-size

---------

Co-authored-by: Philipp Gfeller <philipp.gfeller@post.ch>
gfellerph added a commit that referenced this pull request Jun 29, 2023
* fix: adjust default legend styles sizes

* fix: use dedicated selector to set legend font-size

---------

Co-authored-by: Philipp Gfeller <philipp.gfeller@post.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-day-june-2023 Tickets for people who'd like to get involved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style: default legend styles are too big
3 participants