Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-styles): adds styles for form-range in forced-color/high-contrast mode #159

Merged
merged 9 commits into from
Jul 14, 2022

Conversation

oliverschuerch
Copy link
Contributor

No description provided.

@oliverschuerch oliverschuerch linked an issue Jul 12, 2022 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2022

🦋 Changeset detected

Latest commit: 25fc3d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/web-styles Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

🚀 Preview environment ready: https://preview-159--swisspost-web-frontend.netlify.app/

@oliverschuerch oliverschuerch changed the title 83 windows hcm form range fix(web-styles): adds styles for form-range in forced-color/high-contrast mode Jul 12, 2022
@gfellerph gfellerph self-requested a review July 13, 2022 06:25
'@swisspost/web-styles': patch
---

Moves /.stylelintrc.js to /web-styles/.stylelintrc, so it works correctly with the IDE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change like this is irrelevant to consumers of our packages, therefore I'd not add it to the changelog. Can you delete this changeset?

.changeset/chilled-seahorses-beg.md Outdated Show resolved Hide resolved
packages/web-styles/src/components/form-range.scss Outdated Show resolved Hide resolved
background-color: ButtonFace;
border-color: ButtonBorder;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add :focus-visible styles for HCM? At the moment I can't see my keyboard focus on the slider. Either an outline on the whole slider or just the thumb, but more pronounced than the shadow in non-HCM.

oliverschuerch and others added 6 commits July 13, 2022 09:02
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
use :not selector lists

Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
… list (e.g. :not(.a, .b)) in form-range styles
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thank you!

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows HCM: Form Range
2 participants