-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web-styles): adds styles for form-range in forced-color/high-contrast mode #159
Conversation
🦋 Changeset detectedLatest commit: 25fc3d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Preview environment ready: https://preview-159--swisspost-web-frontend.netlify.app/ |
.changeset/great-parrots-knock.md
Outdated
'@swisspost/web-styles': patch | ||
--- | ||
|
||
Moves /.stylelintrc.js to /web-styles/.stylelintrc, so it works correctly with the IDE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A change like this is irrelevant to consumers of our packages, therefore I'd not add it to the changelog. Can you delete this changeset?
background-color: ButtonFace; | ||
border-color: ButtonBorder; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add :focus-visible styles for HCM? At the moment I can't see my keyboard focus on the slider. Either an outline on the whole slider or just the thumb, but more pronounced than the shadow in non-HCM.
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
use :not selector lists Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
… list (e.g. :not(.a, .b)) in form-range styles
…ced-color/high-contrast mode
…s is only important internally
…style for mozilla
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, thank you!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No description provided.