Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(documentation): add SCSS syntax highlighting #1672

Merged
merged 2 commits into from
Jul 27, 2023
Merged

feat(documentation): add SCSS syntax highlighting #1672

merged 2 commits into from
Jul 27, 2023

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Jul 26, 2023 •
edited

Before After
Screenshot 2023-07-26 at 14-54-33 Getting Started _ Styles - Docs ⋅ Storybook Screenshot 2023-07-26 at 14-53-51 Getting Started _ Styles - Docs ⋅ Storybook

With version 7.1, we can add again support custom language to be syntax highlighted: storybookjs/storybook#23166. This was previously described in this snippet: https://github.com/storybookjs/storybook/blob/e804e039ee6bf743dc7442825c401f4e3f32e678/docs/snippets/common/storybook-preview-register-language-globally.js.mdx#L4

@imagoiq imagoiq self-assigned this Jul 26, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023 •
edited

⚠️ No Changeset found

Latest commit: 0e14069

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jul 26, 2023 •
edited

Preview environment ready: https://preview-1672--swisspost-design-system-next-v7.netlify.app

gfellerph
gfellerph approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@renovate renovate bot force-pushed the renovate/all-minor-patch branch 3 times, most recently from 1b75606 to 940889b Compare July 27, 2023 09:41
@alizedebray alizedebray mentioned this pull request Jul 27, 2023
Merged
1 task
Base automatically changed from renovate/all-minor-patch to main July 27, 2023 12:18
@imagoiq imagoiq force-pushed the doc-v7-add-scss-syntax-highlighting branch from d8c2f2d to c349342 Compare July 27, 2023 13:27
@imagoiq imagoiq force-pushed the doc-v7-add-scss-syntax-highlighting branch from c349342 to ace2eab Compare July 27, 2023 13:39
@imagoiq imagoiq merged commit 0e615d9 into main Jul 27, 2023
6 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@imagoiq imagoiq deleted the doc-v7-add-scss-syntax-highlighting branch August 10, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph approved these changes

@alizedebray alizedebray alizedebray approved these changes

@oliverschuerch oliverschuerch Awaiting requested review from oliverschuerch

Assignees

@imagoiq imagoiq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@imagoiq @swisspost-bot @gfellerph @alizedebray