chore(form-select/custom-select): Fixes floating-label visibility, when rendered without option-tags or without selected option #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(no-option-tags) in the same way as for form-controls (like a placeholders)
…custom-select floating-label examples without options and without selected option
🦋 Changeset detectedLatest commit: 69fafa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Preview environment ready: https://preview-169--swisspost-web-frontend.netlify.app/ |
gfellerph
reviewed
Jul 18, 2022
...mo/src/app/bootstrap/components/form-select/form-select-demo/form-select-demo.component.html
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
gfellerph
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes example for form-select floating-label (with and without options).
Includes examples for custom-select floating-label (with and without options/selected option).
Unifies the static texts of the demo examples.