Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(documentation-v7): workaround for public/assets folder #1766

Merged
merged 1 commit into from Aug 8, 2023
Merged

fix(documentation-v7): workaround for public/assets folder #1766

merged 1 commit into from Aug 8, 2023

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Aug 8, 2023 •
edited

Fix: image

Config is available at original location: https://preview-1766--swisspost-design-system-next-v7.netlify.app/assets/config/test-configuration.json

Similar issues have been reported in storybookjs/storybook#18686

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

⚠️ No Changeset found

Latest commit: c9acbe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@imagoiq imagoiq marked this pull request as ready for review August 8, 2023 12:29
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Aug 8, 2023 •
edited

Preview environment ready: https://preview-1766--swisspost-design-system-next-v7.netlify.app

@imagoiq imagoiq self-assigned this Aug 8, 2023
@imagoiq imagoiq mentioned this pull request Aug 8, 2023
Closed
gfellerph
gfellerph approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it.

@imagoiq imagoiq merged commit caf39f3 into main Aug 8, 2023
11 checks passed
@imagoiq imagoiq deleted the fix-docv7-staticdirs branch August 8, 2023 13:11
@imagoiq imagoiq mentioned this pull request Dec 5, 2023
Merged
imagoiq added a commit that referenced this pull request Dec 5, 2023
@imagoiq
fix(documentation): Try to fix random CI error "on "file already exis…
9012dee 
…ts, mkdir" (#2357)

Try to fix the random CI error of the documentation build: `Error:
EEXIST: file already exists, mkdir './storybook-static/images/packages'`

It happens for example in
https://github.com/swisspost/design-system/actions/runs/7047228581/job/19214036439?pr=2280#step:7:99

It might be linked to this previous issue:
#1766

The issue seems to happen at the vite-builder level and not directly
from Storybook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph approved these changes

@oliverschuerch oliverschuerch Awaiting requested review from oliverschuerch

@alizedebray alizedebray Awaiting requested review from alizedebray

Assignees

@imagoiq imagoiq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imagoiq @swisspost-bot @gfellerph