-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: web styles migrations schematics #183
Conversation
🦋 Changeset detectedLatest commit: c40aacf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # packages/web-styles/src/mixins/_forms.scss # pnpm-lock.yaml
|
||
`npm run test` will run the unit tests, using Jasmine as a runner and test framework. | ||
|
||
### Publishing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section needs to be updated for the changesets publishing workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the README
@@ -85,31 +85,6 @@ | |||
} | |||
} | |||
} | |||
|
|||
.custom-control-input { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this because it was dead code: CWF no longer offers .custom-control-input
's in v5
…/swisspost/common-web-frontend into web-styles-migrations-schematics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, great work!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
--- | ||
|
||
Created a new package offering Migration Schematics for the Web Styles | ||
Removed custom input styles that are no longer used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gfellerph
Just added the changeset.
No description provided.