fix(styles): removes height from form-control-rg in _form.scss #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the problem of textarea and multiselect not behaving as expected when this class was asigned to them.
b1aserlu
requested review from
gfellerph,
oliverschuerch,
alizedebray and
imagoiq
as code owners
🦋 Changeset detectedLatest commit: 9b997a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview environment ready: https://preview-1830--swisspost-web-frontend.netlify.app |
davidritter-dotcom
approved these changes
Aug 23, 2023
…-with-class-form-control-rg
gfellerph
requested changes
Aug 29, 2023
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
gfellerph
approved these changes
Aug 30, 2023
gfellerph
deleted the
1784-remove-fix-height-from-textarea-element-with-class-form-control-rg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem of textarea and multiselect not behaving as expected when this class was asigned to them.
The select component used form-select-rg wich was pretty much an alias for form-control-rg thus the issue #1777 will also be fixed by this change.
Note: The "Text-Input" component should still have the same fixed height after this change.