chore(tabs): Refactors tabs styles, to get rid of the class text-auto #187
Conversation
…round mixin So components can ad styles, if there is set a background-class on any parent element
Levels up the tab-title specificity, so nav-item styles do not overwrite color, etc. Gets rid of @supports media-query, because it's no longer needed
🦋 Changeset detectedLatest commit: 87bf2bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -33,13 +34,20 @@ | |||
| } | |||
|
|
|||
| .tabs { | |||
| --tabs-title-bg-opacity: 1; | |||
There was a problem hiding this comment.
Do we want to declare default variables for components within the :root { } selector (but inside this file)? This would enable the whole page to make use of that variable if tabs are included (might be necessary for the page to use this var somewhere else, in this case I don't see it as very useful but I would like to set a precedent).
There was a problem hiding this comment.
I don't see the point, why should anyone use this variable outside the tabs-component?
I would rather discuss why this is not a scss-variable.
Otherwise I would always prefer to declare css-variables like this in the component itself and not pollute the :root selector with it.
But maybe your arguments will make sense to me if you explain them.
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.