Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): define max-width for badges #1892

Merged
merged 15 commits into from
Oct 31, 2023

Conversation

davidritter-dotcom
Copy link
Contributor

No description provided.

@davidritter-dotcom davidritter-dotcom requested a review from a team as a code owner August 31, 2023 07:00
@davidritter-dotcom davidritter-dotcom linked an issue Aug 31, 2023 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

🦋 Changeset detected

Latest commit: e475679

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@swisspost/design-system-documentation Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components Patch
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Aug 31, 2023

Preview environment ready: https://preview-1892--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-1892--swisspost-design-system-next.netlify.app

Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on the initial CR of @gfellerph.

Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset!

packages/styles/src/placeholders/badge.scss Show resolved Hide resolved
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overflow behaviour seems good now, there are just two suggestions I'd like to address.

.changeset/polite-panthers-care.md Outdated Show resolved Hide resolved
packages/styles/src/placeholders/badge.scss Outdated Show resolved Hide resolved
davidritter-dotcom and others added 2 commits October 10, 2023 09:55
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
davidritter-dotcom and others added 2 commits October 10, 2023 14:04
Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch>
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davidritter-dotcom davidritter-dotcom merged commit cfb5bdd into main Oct 31, 2023
10 checks passed
@davidritter-dotcom davidritter-dotcom deleted the 1159-styles-define-max-width-for-badges branch October 31, 2023 08:15
gfellerph pushed a commit that referenced this pull request Nov 2, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/design-system-components@1.6.0

### Minor Changes

- Added component exports to the src/index.ts files, to include them in
the dist/index.js and dist/index.esm.js output files and therefore fix
our stencil setup. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[`f74c9662`](f74c966))

- Added a `post-collapsible` event emitted when the collapse element is
shown or hidden. (by [@alizedebray](https://github.com/alizedebray) with
[#2079](#2079))

- Added the `post-accordion` component. (by
[@alizedebray](https://github.com/alizedebray) with
[#2079](#2079))

### Patch Changes

- Upgraded builder Stenciljs from version 3 to 4. No user visible
changes are expected. (by [@imagoiq](https://github.com/imagoiq) with
[#2116](#2116))
-   Updated dependencies:
    -   @swisspost/design-system-styles@6.4.3

## @swisspost/internet-header@1.12.0

### Minor Changes

- Added component exports to the src/index.ts files, to include them in
the dist/index.js and dist/index.esm.js output files and therefore fix
our stencil setup. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[`f74c9662`](f74c966))

### Patch Changes

- Added logout-url property to override the URL provided by the portal
config on the internet-header component. (by
[@imagoiq](https://github.com/imagoiq) with
[#2114](#2114))

- Upgraded builder Stenciljs from version 3 to 4. No user visible
changes are expected. (by [@imagoiq](https://github.com/imagoiq) with
[#2116](#2116))

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.4.3

## @swisspost/design-system-icons@1.0.13

### Patch Changes

- Updated icons number 8000. (by
[@swisspost-bot](https://github.com/swisspost-bot) with
[#2151](#2151))

## @swisspost/design-system-intranet-header@5.0.3

### Patch Changes

- Fixed default user image sometimes blocked by CORS policies. (by
[@alizedebray](https://github.com/alizedebray) with
[#2165](#2165))
-   Updated dependencies:
    -   @swisspost/design-system-styles@6.4.3

## @swisspost/design-system-styles@6.4.3

### Patch Changes

- Changed dropdown icon for the select component and adjusted the size
of the icon. (by [@b1aserlu](https://github.com/b1aserlu) with
[#2164](#2164))

- Added `table-mono` variant for table component. (by
[@imagoiq](https://github.com/imagoiq) with
[#2106](#2106))

- Set a `max-width` for badges and add ellipsis for overflowing text.
(by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#1892](#1892))

- Applied autoprefixer to distributed sass files. Sass files will now
contain prefixes for supported browsers according to the browserslist
file. (by [@imagoiq](https://github.com/imagoiq) with
[#2115](#2115))

## @swisspost/design-system-documentation@2.3.0

### Minor Changes

- Used the new tabs to improve the presentation of some code snippets.
(by [@b1aserlu](https://github.com/b1aserlu) with
[#2130](#2130))

- Added the `post-accordion` component. (by
[@alizedebray](https://github.com/alizedebray) with
[#2079](#2079))

- Added a new documentation for sizing. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#2028](#2028))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-icons@1.0.13
    -   @swisspost/design-system-styles@6.4.3
    -   @swisspost/internet-header@1.12.0
    -   @swisspost/design-system-components@1.6.0
    -   @swisspost/design-system-components-react@1.0.20

## @swisspost/design-system-components-react@1.0.20

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@1.6.0

## @swisspost/design-system-demo@7.0.3

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.4.3
    -   @swisspost/design-system-intranet-header@5.0.3

## @swisspost/design-system-intranet-header-workspace@3.0.3

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.4.3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles: Define max-width for badges
4 participants