-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): define max-width for badges #1892
fix(styles): define max-width for badges #1892
Conversation
🦋 Changeset detectedLatest commit: e475679 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview environment ready: https://preview-1892--swisspost-web-frontend.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on the initial CR of @gfellerph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changeset!
packages/documentation/src/stories/components/badge/badge.stories.ts
Outdated
Show resolved
Hide resolved
…ies.ts Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overflow behaviour seems good now, there are just two suggestions I'd like to address.
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
packages/documentation/src/stories/components/badge/badge.stories.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Oliver Schürch <oliver.schuerch@post.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Kudos, SonarCloud Quality Gate passed!
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/design-system-components@1.6.0 ### Minor Changes - Added component exports to the src/index.ts files, to include them in the dist/index.js and dist/index.esm.js output files and therefore fix our stencil setup. (by [@oliverschuerch](https://github.com/oliverschuerch) with [`f74c9662`](f74c966)) - Added a `post-collapsible` event emitted when the collapse element is shown or hidden. (by [@alizedebray](https://github.com/alizedebray) with [#2079](#2079)) - Added the `post-accordion` component. (by [@alizedebray](https://github.com/alizedebray) with [#2079](#2079)) ### Patch Changes - Upgraded builder Stenciljs from version 3 to 4. No user visible changes are expected. (by [@imagoiq](https://github.com/imagoiq) with [#2116](#2116)) - Updated dependencies: - @swisspost/design-system-styles@6.4.3 ## @swisspost/internet-header@1.12.0 ### Minor Changes - Added component exports to the src/index.ts files, to include them in the dist/index.js and dist/index.esm.js output files and therefore fix our stencil setup. (by [@oliverschuerch](https://github.com/oliverschuerch) with [`f74c9662`](f74c966)) ### Patch Changes - Added logout-url property to override the URL provided by the portal config on the internet-header component. (by [@imagoiq](https://github.com/imagoiq) with [#2114](#2114)) - Upgraded builder Stenciljs from version 3 to 4. No user visible changes are expected. (by [@imagoiq](https://github.com/imagoiq) with [#2116](#2116)) - Updated dependencies: - @swisspost/design-system-styles@6.4.3 ## @swisspost/design-system-icons@1.0.13 ### Patch Changes - Updated icons number 8000. (by [@swisspost-bot](https://github.com/swisspost-bot) with [#2151](#2151)) ## @swisspost/design-system-intranet-header@5.0.3 ### Patch Changes - Fixed default user image sometimes blocked by CORS policies. (by [@alizedebray](https://github.com/alizedebray) with [#2165](#2165)) - Updated dependencies: - @swisspost/design-system-styles@6.4.3 ## @swisspost/design-system-styles@6.4.3 ### Patch Changes - Changed dropdown icon for the select component and adjusted the size of the icon. (by [@b1aserlu](https://github.com/b1aserlu) with [#2164](#2164)) - Added `table-mono` variant for table component. (by [@imagoiq](https://github.com/imagoiq) with [#2106](#2106)) - Set a `max-width` for badges and add ellipsis for overflowing text. (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#1892](#1892)) - Applied autoprefixer to distributed sass files. Sass files will now contain prefixes for supported browsers according to the browserslist file. (by [@imagoiq](https://github.com/imagoiq) with [#2115](#2115)) ## @swisspost/design-system-documentation@2.3.0 ### Minor Changes - Used the new tabs to improve the presentation of some code snippets. (by [@b1aserlu](https://github.com/b1aserlu) with [#2130](#2130)) - Added the `post-accordion` component. (by [@alizedebray](https://github.com/alizedebray) with [#2079](#2079)) - Added a new documentation for sizing. (by [@b1aserlu](https://github.com/b1aserlu) with [#2028](#2028)) ### Patch Changes - Updated dependencies: - @swisspost/design-system-icons@1.0.13 - @swisspost/design-system-styles@6.4.3 - @swisspost/internet-header@1.12.0 - @swisspost/design-system-components@1.6.0 - @swisspost/design-system-components-react@1.0.20 ## @swisspost/design-system-components-react@1.0.20 ### Patch Changes - Updated dependencies: - @swisspost/design-system-components@1.6.0 ## @swisspost/design-system-demo@7.0.3 ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.4.3 - @swisspost/design-system-intranet-header@5.0.3 ## @swisspost/design-system-intranet-header-workspace@3.0.3 ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.4.3 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
No description provided.