Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: ngb Alert Buttons #2

Merged
merged 7 commits into from
Apr 12, 2022
Merged

Conversation

Janobob
Copy link
Member

@Janobob Janobob commented Apr 4, 2022

  • fix(alerts): use correct color for close button and success alerts

@Janobob Janobob requested a review from gfellerph April 4, 2022 09:19
@Janobob Janobob self-assigned this Apr 4, 2022
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2022

🦋 Changeset detected

Latest commit: bbed7d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/web-styles Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gfellerph gfellerph added 🐞 bug Something isn't working and removed 🐞 bug Something isn't working labels Apr 4, 2022
@Janobob Janobob added the 🐞 bug Something isn't working label Apr 5, 2022
Sie haben eine neue Nachricht von Paula erhalten.
</p>
</div>
<div class="alert alert-info alert-action pi-1001 alert-fixed-bottom" role="alert" #ex1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Janobob is this class new in Bootstrap 5.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know really. I'd a look at others alerts which where working on the fullwidth and there's a specific rule:

.alert:not(.alert-fixed-bottom) {
    max-width: 1441px;
}

Which comes from the bootstrap scss file itself.

@gfellerph gfellerph merged commit 4c7f1ce into main Apr 12, 2022
@gfellerph gfellerph deleted the fix/regression-ngb-alert-buttons branch April 12, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants