fix(styles): Dismissible toast cannot be closed #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d3052a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview environment ready: https://preview-2008--swisspost-web-frontend.netlify.app |
imagoiq
requested review from
b1aserlu and
davidritter-dotcom
as code owners
gfellerph
approved these changes
Oct 2, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
gfellerph
pushed a commit
that referenced
this pull request
Oct 4, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/design-system-components@1.5.0 ### Minor Changes - Added the `post-tooltip` component. (by [@gfellerph](https://github.com/gfellerph) with [#1879](#1879)) - Created the web component variant for the alert component. (by [@alizedebray](https://github.com/alizedebray) with [#1085](#1085)) ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.4.1 ## @swisspost/internet-header@1.10.0 ### Minor Changes - Enabled nesting the header in a different scroll container than the `<body>` element. The header stickyness and logo animation logic will automatically attach to the nearest scrolling container instead of the document when nested in a container that has `overflow: auto | scroll` set. (by [@alizedebray](https://github.com/alizedebray) with [#1855](#1855)) - Added ability to toggle programmatically an overlay associated with a button using the `toggleOverlayById` method. (by [@imagoiq](https://github.com/imagoiq) with [#1838](#1838)) ### Patch Changes - Fixed an issue with custom configuration that was not applied when the prop "language" was not set on the internet header. (by [@alizedebray](https://github.com/alizedebray) with [#1855](#1855)) - Updated dependencies: - @swisspost/design-system-styles@6.4.1 ## @swisspost/design-system-intranet-header@5.0.1 ### Patch Changes - Removed bound between logo and language to allow any language to display the logo. (by [@imagoiq](https://github.com/imagoiq) with [#2009](#2009)) - Updated dependencies: - @swisspost/design-system-styles@6.4.1 ## @swisspost/design-system-styles@6.4.1 ### Patch Changes - Removed bound between logo and language to allow any language to display the logo. (by [@imagoiq](https://github.com/imagoiq) with [#2009](#2009)) - Reduced the gap between the alert body and action buttons. (by [@alizedebray](https://github.com/alizedebray) with [#1085](#1085)) - Removed duplicated close button on toast when using ngx-toastr programatically. (by [@imagoiq](https://github.com/imagoiq) with [#2011](#2011)) - Updated and added the gaps between the title and the link-list in the `.topic-teaser-content` class to comply with the figma design. (by [@b1aserlu](https://github.com/b1aserlu) with [#1927](#1927)) - Added missing pointer-events to allow a dismissible toast to be closed interactively. (by [@imagoiq](https://github.com/imagoiq) with [#2008](#2008)) - Updated icons to display as mask images, this way their color can be set by adjusting the CSS `background-color` property. (by [@alizedebray](https://github.com/alizedebray) with [#1945](#1945)) ## @swisspost/design-system-documentation@2.1.0 ### Minor Changes - Added the `post-tooltip` component. (by [@gfellerph](https://github.com/gfellerph) with [#1879](#1879)) - Integrated the google tag manager and the basic events (page_context, page_change) to the documentation. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#1951](#1951)) - Created the web component variant for the alert component. (by [@alizedebray](https://github.com/alizedebray) with [#1085](#1085)) ### Patch Changes - Used the post-icon component instead of `.pi` classes to display icons in stories. (by [@alizedebray](https://github.com/alizedebray) with [#1945](#1945)) - Added deprecation alerts for `.form-control-rg`, `.form-control-md`, `.form-select-rg` and `.form-select-md` form-control variants. (by [@b1aserlu](https://github.com/b1aserlu) with [#1882](#1882)) - Updated dependencies: - @swisspost/design-system-components@1.5.0 - @swisspost/design-system-styles@6.4.1 - @swisspost/internet-header@1.10.0 - @swisspost/design-system-components-react@1.0.18 ## @swisspost/design-system-components-angular@3.0.1 ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.4.1 ## @swisspost/design-system-components-react@1.0.18 ### Patch Changes - Updated dependencies: - @swisspost/design-system-components@1.5.0 ## @swisspost/design-system-demo@7.0.1 ### Patch Changes - Updated the installation intructions for the Intranet Header. (by [@alizedebray](https://github.com/alizedebray) with [#1942](#1942)) - Added deprecation alerts for `.form-control-rg`, `.form-control-md`, `.form-select-rg` and `.form-select-md` form-control variants. (by [@b1aserlu](https://github.com/b1aserlu) with [#1882](#1882)) - Fixed ngBootstrap documentation links. (by [@imagoiq](https://github.com/imagoiq) with [#1987](#1987)) - Updated dependencies: - @swisspost/design-system-intranet-header@5.0.1 - @swisspost/design-system-styles@6.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add the pointer-events on toast class like it was before: https://github.com/swisspost/design-system/pull/1350/files#diff-6e627fce6f996f66a6813b23cbff252b163014c62faaceeadbd5c2d54648b92fL99