fix(styles): fix active switch in Chrome #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2299613 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Preview environment ready: https://preview-2090--swisspost-web-frontend.netlify.app |
imagoiq
reviewed
Oct 18, 2023
| @@ -14,6 +14,12 @@ | |||
| background-color: currentColor; | |||
| } | |||
|
|
|||
| @mixin remove-icon() { | |||
| /* stylelint-disable-next-line property-no-vendor-prefix */ | |||
| -webkit-mask-image: none; | |||
There was a problem hiding this comment.
Shouldn't it be managed by https://github.com/swisspost/design-system/blob/main/packages/styles/gulpfile.js#L117 ?
There was a problem hiding this comment.
It should but it is not...
There was a problem hiding this comment.
It looks like to work with this playground, our browserslist and an older version of Autoprefixer: https://autoprefixer.github.io/
There was a problem hiding this comment.
I also checked the playground but it is currently not working for our package.
The quick fix may be temporary, but it would be nice if we could merge it soon since the bug is in production and we have already received support requests about it. I created ticket #2103 to fix the autoprefixer in another release.
imagoiq
approved these changes
Oct 19, 2023
gfellerph
pushed a commit
that referenced
this pull request
Oct 24, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/internet-header@1.11.0 ### Minor Changes - Added a new button to clear the text in the search box. (by [@b1aserlu](https://github.com/b1aserlu) with [#2036](#2036)) ### Patch Changes - Added hide-buttons prop to hide all breadcrumbs buttons. (by [@imagoiq](https://github.com/imagoiq) with [#2027](#2027)) - Fixed internet-header search focus truncated on focus-within. (by [@imagoiq](https://github.com/imagoiq) with [#2043](#2043)) - Compressed styles output. (by [@imagoiq](https://github.com/imagoiq) with [#2098](#2098)) - Updated dependencies: - @swisspost/design-system-styles@6.4.2 ## @swisspost/design-system-components@1.5.1 ### Patch Changes - Fixed misplaced custom icons in “post-alert” elements with actions. (by [@alizedebray](https://github.com/alizedebray) with [#2094](#2094)) - Updated the keyboard navigation on the `post-tabs` component. (by [@alizedebray](https://github.com/alizedebray) with [#2093](#2093)) - Fixed tabs count announcement with VoiceOver. (by [@imagoiq](https://github.com/imagoiq) with [#2047](#2047)) - Compressed styles output. (by [@imagoiq](https://github.com/imagoiq) with [#2098](#2098)) - Updated dependencies: - @swisspost/design-system-styles@6.4.2 ## @swisspost/design-system-intranet-header@5.0.2 ### Patch Changes - Changed the main title of the intranet-header from `<h2>` to `<h1>`. (by [@b1aserlu](https://github.com/b1aserlu) with [#2104](#2104)) - Updated dependencies: - @swisspost/design-system-styles@6.4.2 ## @swisspost/design-system-styles@6.4.2 ### Patch Changes - Refactored the grid-system: adjusted container paddings, added responsive gutter-widths. Updated grid docs. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#2045](#2045)) - Added small variants for checkbox and radio buttons. Lowered font-size of validation blocks for form elements. (by [@imagoiq](https://github.com/imagoiq) with [#2086](#2086)) - Fixed missing active tab border on HTML component. (by [@imagoiq](https://github.com/imagoiq) with [#2037](#2037)) - Fixed active switch control showing a check icon in Chrome. (by [@alizedebray](https://github.com/alizedebray) with [#2090](#2090)) ## @swisspost/design-system-documentation@2.2.0 ### Minor Changes - Added a docs page for our spacing utilities (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#1988](#1988)) - Added a docs page for our grid-system. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#1947](#1947)) ### Patch Changes - Refactored the grid-system: adjusted container paddings, added responsive gutter-widths. Updated grid docs. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#2045](#2045)) - Fixed the "fixed" control in the `post-alert` documentation. (by [@alizedebray](https://github.com/alizedebray) with [#2094](#2094)) - Updated dependencies: - @swisspost/internet-header@1.11.0 - @swisspost/design-system-components@1.5.1 - @swisspost/design-system-styles@6.4.2 - @swisspost/design-system-components-react@1.0.19 ## @swisspost/design-system-components-angular@3.0.2 ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.4.2 ## @swisspost/design-system-components-react@1.0.19 ### Patch Changes - Updated dependencies: - @swisspost/design-system-components@1.5.1 ## @swisspost/design-system-demo@7.0.2 ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.4.2 - @swisspost/design-system-intranet-header@5.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.