Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(styles): update accordion #2310

Merged
merged 10 commits into from
Nov 30, 2023
Merged

chore(styles): update accordion #2310

merged 10 commits into from
Nov 30, 2023

Conversation

alizedebray
Copy link
Contributor

No description provided.

@alizedebray alizedebray linked an issue Nov 27, 2023 that may be closed by this pull request
Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: ad35eed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@swisspost/design-system-styles Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-components Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 27, 2023

Preview environment ready: https://preview-2310--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2310--swisspost-design-system-next.netlify.app

@alizedebray alizedebray force-pushed the 1087-accordeon-optimization branch 3 times, most recently from 11102bd to d276397 Compare November 29, 2023 11:32
@alizedebray alizedebray marked this pull request as ready for review November 29, 2023 12:43
@alizedebray alizedebray requested a review from a team as a code owner November 29, 2023 12:43
Copy link
Contributor

@imagoiq imagoiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only remaining part is #2122. Perhaps you want to address it in this PR as well?

@alizedebray alizedebray merged commit 8366673 into main Nov 30, 2023
7 checks passed
@alizedebray alizedebray deleted the 1087-accordeon-optimization branch November 30, 2023 07:44
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gfellerph pushed a commit that referenced this pull request Dec 6, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/design-system-migrations@1.0.0

### Major Changes

- Separated the migration schematics from the styles to their own
package `@swisspost/design-system-migrations`. (by
[@alizedebray](https://github.com/alizedebray) with
[#2270](#2270))

## @swisspost/design-system-styles@6.5.0

### Minor Changes

- Separated the migration schematics from the styles to their own
package `@swisspost/design-system-migrations`. (by
[@alizedebray](https://github.com/alizedebray) with
[#2270](#2270))

### Patch Changes

- Updated the accordion styles. (by
[@alizedebray](https://github.com/alizedebray) with
[#2310](#2310))

- Fixed overflow on datepicker select variant. (by
[@imagoiq](https://github.com/imagoiq) with
[#2319](#2319))

- Added small variant to floating label select. (by
[@gfellerph](https://github.com/gfellerph) with
[#2368](#2368))

- Updated select styles to match design. (by
[@imagoiq](https://github.com/imagoiq) with
[#2312](#2312))

- Fixed intranet-header sticky navigation on mobile which prevent
interactivity on the page within a certain viewport width. (by
[@imagoiq](https://github.com/imagoiq) with
[#2320](#2320))

- Fixed spacing regression on form switch label. (by
[@imagoiq](https://github.com/imagoiq) with
[#2356](#2356))

- Fixed active color and chevron display of the ngb-pagination component
in High Contrast Mode. (by [@imagoiq](https://github.com/imagoiq) with
[#2366](#2366))

- Transformed the gap between the label and the radio/checkbox/switch
into a clickable area. (by [@imagoiq](https://github.com/imagoiq) with
[#2333](#2333))

## @swisspost/design-system-components@1.6.3

### Patch Changes

- Defined @stencil/core and @stencil/store as a devDependency to avoid
compatibilities issues. (by [@imagoiq](https://github.com/imagoiq) with
[#2313](#2313))
-   Updated dependencies:
    -   @swisspost/design-system-styles@6.5.0

## @swisspost/design-system-icons@1.0.16

### Patch Changes

- Added icons number 2493, 2557, 2558, 2559, 2560, 2561, 2562, 2563,
2564 and 2565.Updated icons number 1000, 1001, 1002, 1003, 1004, 1005,
1006, 1007, 1008, 1009, 1010, 1011, 1012, 1013, 1014, 1015, 1016, 1017,
1018, 1019, 1020, 1021, 1022, 1023, 1024, 1025, 1026, 1029, 1030, 1031,
1034, 1035, 1036, 1037, 1038, 1039, 1040, 1042, 1043, 1044, 1045, 1046,
1047, 1048, 1049, 2000, 2001, 2002, 2005, 2007, 2008, 2009, 2010, 2011,
2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2021, 2022, 2023, 2024,
2025, 2026, 2027, 2028, 2029, 2030, 2032, 2034, 2036, 2053, 2054, 2057,
2059, 2060, 2062, 2069, 2071, 2072, 2073, 2074, 2075, 2076, 2077, 2078,
2079, 2080, 2081, 2082, 2083, 2084, 2085, 2086, 2087, 2088, 2089, 2090,
2091, 2092, 2093, 2094, 2095, 2096, 2097, 2099, 2100, 2102, 2103, 2104,
2106, 2108, 2109, 2110, 2111, 2112, 2113, 2114, 2115, 2116, 2117, 2118,
2119, 2120, 2121, 2122, 2123, 2124, 2125, 2126, 2127, 2128, 2129, 2130,
2131, 2132, 2133, 2134, 2135, 2136, 2137, 2138, 2139, 2140, 2141, 2142,
2143, 2144, 2145, 2146, 2147, 2148, 2149, 2150, 2151, 2152, 2153, 2154,
2155, 2156, 2157, 2158, 2159, 2160, 2161, 2162, 2163, 2164, 2165, 2166,
2167, 2168, 2169, 2170, 2171, 2172, 2173, 2174, 2175, 2176, 2177, 2178,
2179, 2180, 2181, 2182, 2183, 2184, 2185, 2186, 2187, 2188, 2189, 2190,
2191, 2192, 2193, 2194, 2195, 2196, 2197, 2198, 2199, 2200, 2201, 2202,
2203, 2205, 2206, 2207, 2208, 2209, 2210, 2211, 2212, 2213, 2214, 2215,
2216, 2217, 2218, 2219, 2220, 2221, 2222, 2223, 2224, 2225, 2226, 2227,
2228, 2229, 2230, 2231, 2232, 2233, 2234, 2235, 2236, 2237, 2238, 2239,
2240, 2241, 2242, 2243, 2244, 2245, 2246, 2247, 2248, 2249, 2250, 2251,
2252, 2253, 2254, 2255, 2256, 2257, 2258, 2259, 2260, 2261, 2262, 2263,
2264, 2265, 2266, 2267, 2268, 2269, 2270, 2271, 2272, 2273, 2274, 2275,
2276, 2277, 2278, 2279, 2280, 2281, 2282, 2283, 2284, 2285, 2286, 2287,
2288, 2289, 2290, 2291, 2292, 2293, 2294, 2295, 2296, 2297, 2298, 2299,
2300, 2301, 2302, 2303, 2304, 2305, 2306, 2307, 2308, 2309, 2310, 2311,
2312, 2313, 2314, 2315, 2316, 2317, 2318, 2319, 2320, 2321, 2322, 2323,
2324, 2325, 2326, 2327, 2328, 2329, 2330, 2331, 2332, 2333, 2334, 2335,
2336, 2337, 2338, 2339, 2340, 2341, 2342, 2343, 2344, 2345, 2346, 2347,
2348, 2349, 2350, 2351, 2352, 2353, 2354, 2355, 2356, 2357, 2358, 2359,
2360, 2361, 2362, 2363, 2364, 2365, 2366, 2367, 2368, 2369, 2370, 2371,
2372, 2373, 2374, 2375, 2376, 2377, 2378, 2379, 2380, 2381, 2382, 2383,
2384, 2385, 2386, 2387, 2388, 2389, 2390, 2391, 2392, 2393, 2394, 2395,
2396, 2397, 2398, 2399, 2400, 2401, 2402, 2403, 2404, 2405, 2406, 2407,
2408, 2409, 2410, 2411, 2412, 2413, 2414, 2415, 2416, 2417, 2418, 2419,
2420, 2421, 2422, 2423, 2424, 2425, 2426, 2427, 2428, 2429, 2430, 2431,
2432, 2433, 2434, 2435, 2436, 2437, 2438, 2439, 2440, 2441, 2442, 2443,
2444, 2445, 2446, 2447, 2448, 2449, 2450, 2451, 2452, 2453, 2454, 2455,
2456, 2457, 2458, 2459, 2460, 2461, 2462, 2463, 2464, 2465, 2466, 2467,
2468, 2469, 2470, 2471, 2472, 2473, 2474, 2475, 2476, 2477, 2478, 2479,
2480, 2481, 2482, 2483, 2484, 2485, 2486, 2487, 2488, 2489, 2490, 2491,
2492, 2494, 2495, 2496, 2497, 2498, 2499, 2500, 2501, 2502, 2503, 2504,
2505, 2506, 2507, 2508, 2509, 2510, 2511, 2512, 2513, 2514, 2515, 2516,
2517, 2518, 2519, 2520, 2521, 2522, 2523, 2524, 2525, 2526, 2527, 2528,
2529, 2530, 2531, 2532, 2533, 2534, 2535, 2536, 2537, 2538, 2539, 2540,
2541, 2542, 2543, 2544, 2545, 2546, 2547, 2548, 2549, 2550, 2551, 2552,
2553, 2554, 2555, 2556, 3000, 3001, 3002, 3003, 3004, 3005, 3006, 3007,
3008, 3009, 3010, 3011, 3012, 3013, 3014, 3015, 3016, 3017, 3018, 3019,
3026, 3033, 3034, 3036, 3037, 3038, 3039, 3040, 3041, 3042, 3043, 3044,
3045, 3046, 3047, 3048, 3049, 3050, 3051, 3052, 3053, 3054, 3055, 3056,
3057, 3058, 3059, 3060, 3061, 3062, 3063, 3064, 3065, 3066, 3067, 3068,
3069, 3070, 3071, 3072, 3073, 3074, 3075, 3076, 3077, 3078, 3079, 3080,
3081, 3082, 3083, 3084, 3085, 3086, 3087, 3088, 3089, 3090, 3091, 3092,
3093, 3094, 3095, 3096, 3097, 3098, 3099, 3100, 3101, 3102, 3103, 3104,
3105, 3106, 3107, 3108, 3109, 3110, 3111, 3112, 3113, 3114, 3115, 3116,
3117, 3118, 3119, 3120, 3121, 3122, 3123, 3124, 3125, 3126, 3127, 3128,
3129, 3130, 3131, 3132, 3133, 3134, 3135, 3137, 3138, 3139, 3140, 3141,
3142, 3143, 3146, 3147, 3148, 3149, 3150, 3151, 3152, 3153, 3154, 3155,
3156, 3157, 3158, 3159, 3160, 3161, 3163, 3164, 3165, 3168, 3170, 3171,
3172, 3173, 3174, 3175, 3176, 3177, 3178, 3179, 3180, 3181, 3182, 3183,
3184, 3185, 3186, 3187, 3188, 3189, 3190, 3191, 3193, 3194, 3195, 3196,
3197, 3198, 3199, 3200, 3203, 3204, 3205, 3206, 3208, 3209, 3210, 3211,
3212, 3213, 3214, 3215, 3216, 3217, 3218, 3219, 3220, 3221, 3222, 3223,
3224, 3225, 3226, 3227, 3228, 3229, 3230, 3231, 3232, 3233, 3234, 3235,
3236, 3237, 3238, 3239, 3240, 3241, 3242, 3243, 3244, 3245, 3246, 3247,
3248, 3249, 3250, 3251, 3252, 3253, 3254, 3255, 3256, 3257, 3258, 3259,
3260, 8000, 8001, 8002, 8004, 8005, 8006, 8007, 8008, 8009, 8010, 8011,
8012, 8013, 8014, 8015, 8016, 8017, 8018 and 8019. (by
[@swisspost-bot](https://github.com/swisspost-bot) with
[#2346](#2346))

## @swisspost/internet-header@1.13.1

### Patch Changes

- Defined @stencil/core and @stencil/store as a devDependency to avoid
compatibilities issues. (by [@imagoiq](https://github.com/imagoiq) with
[#2313](#2313))

- Fixed position of close button on click or on focus in the help
overlay. (by [@imagoiq](https://github.com/imagoiq) with
[#2365](#2365))

- Fixed display of active navigation in High Contrast Mode. (by
[@imagoiq](https://github.com/imagoiq) with
[#2314](#2314))

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.5.0

## @swisspost/design-system-intranet-header@5.0.5

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.5.0

## @swisspost/design-system-documentation@2.6.0

### Minor Changes

- Added a Since v1 label on all the components that got introduced in
Version 1 (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#2290](#2290))

### Patch Changes

- Removed badge size class at wrapper level. It's only used inside the
label. (by [@imagoiq](https://github.com/imagoiq) with
[#2294](#2294))

- Added small variant to floating label select. (by
[@gfellerph](https://github.com/gfellerph) with
[#2368](#2368))

- Updated select styles to match design. (by
[@imagoiq](https://github.com/imagoiq) with
[#2312](#2312))

-   Updated dependencies:
    -   @swisspost/design-system-icons@1.0.16
    -   @swisspost/design-system-styles@6.5.0
    -   @swisspost/internet-header@1.13.1
    -   @swisspost/design-system-components@1.6.3
    -   @swisspost/design-system-components-react@1.0.23

## @swisspost/design-system-components-react@1.0.23

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@1.6.3

## @swisspost/design-system-demo@7.1.1

### Patch Changes

- Updated ng-bootstrap component-based accordion example in favor of the
directive-based implementation. (by
[@gfellerph](https://github.com/gfellerph) with
[#2368](#2368))

- Deprecated Bootstrap accordions in favor of the post-accordion web
component. (by [@alizedebray](https://github.com/alizedebray) with
[#2310](#2310))

- Update the commands to run the Design System migrations. (by
[@alizedebray](https://github.com/alizedebray) with
[#2270](#2270))

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.5.0
    -   @swisspost/design-system-intranet-header@5.0.5

## @swisspost/design-system-intranet-header-workspace@3.0.5

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.5.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordeon Optimization
3 participants