Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(documentation): Document collapseChange event on post-accordion #2620

Merged
merged 8 commits into from
Feb 19, 2024
Merged

feat(documentation): Document collapseChange event on post-accordion #2620

merged 8 commits into from
Feb 19, 2024

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Feb 7, 2024 •
edited
Loading

No description provided.

@imagoiq imagoiq self-assigned this Feb 7, 2024
@imagoiq imagoiq requested a review from a team as a code owner February 7, 2024 10:05
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 87da944

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imagoiq imagoiq linked an issue Feb 7, 2024 that may be closed by this pull request
Add collapseChange event to post-accordion #2572
Closed
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Feb 7, 2024 •
edited
Loading

Preview environment ready: https://preview-2620--swisspost-design-system-next.netlify.app

@imagoiq imagoiq marked this pull request as draft February 8, 2024 10:48
@imagoiq imagoiq changed the title feat(components, documentation): Add new itemsCollapseChange event on post-accordion feat(documentation): Document collapseChange event on post-accordion Feb 8, 2024
@imagoiq imagoiq marked this pull request as ready for review February 8, 2024 13:38
@imagoiq
Merge branch 'main' into feat/2572-collapse-change-event-on-accordion
106e8fd 
# Conflicts:
#	packages/documentation/src/stories/components/accordion/accordion.stories.ts
oliverschuerch
oliverschuerch requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this event fire on the post-accordion or the post-accordion-item component or on both?

There are other things we should document about the post-accordion-item, like the collapsed or headingLevel attribute or the toggle method.
In my opinion, it would make more sense, to add the whole control table for the post-accordion-item below the control table for the post-accordion and add some headings for both tables, so we are sure that everything from both components is documented, whenever we change something on them.

@imagoiq imagoiq mentioned this pull request Feb 14, 2024
Closed
@imagoiq
Copy link
Contributor Author

imagoiq commented Feb 14, 2024

Does this event fire on the post-accordion or the post-accordion-item component or on both?

There are other things we should document about the post-accordion-item, like the collapsed or headingLevel attribute or the toggle method. In my opinion, it would make more sense, to add the whole control table for the post-accordion-item below the control table for the post-accordion and add some headings for both tables, so we are sure that everything from both components is documented, whenever we change something on them.

It fires on both. For post-accordion-item, it's a good idea, I've created a ticket: #2654

@imagoiq
Merge branch 'main' into feat/2572-collapse-change-event-on-accordion
f29d53d 
# Conflicts:
#	packages/documentation/src/stories/components/accordion/accordion.stories.ts
@imagoiq
Fixed test
87da944
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@imagoiq imagoiq merged commit aa4f500 into main Feb 19, 2024
8 checks passed
@imagoiq imagoiq deleted the feat/2572-collapse-change-event-on-accordion branch February 19, 2024 10:00
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Merged
gfellerph pushed a commit that referenced this pull request Feb 20, 2024
@github-actions
chore(changesets): 🦋📦 publish packages (#2631)
f5ea879 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/design-system-icons@1.3.0

### Minor Changes

- Added icon number 2575. (by
[@swisspost-bot](https://github.com/swisspost-bot) with
[#2677](#2677))

## @swisspost/design-system-components@2.0.2

### Patch Changes

- Fixed double lines between accordion items on chrome/safari. (by
[@imagoiq](https://github.com/imagoiq) with
[#2615](#2615))

- Fixed two issues with tooltips and Angular integration. Tooltips are
now being displayed on buttons that are added to the DOM asynchronously
and tooltip elements are no longer duplicated on route change. (by
[@gfellerph](https://github.com/gfellerph) with
[#2621](#2621))

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.2

## @swisspost/design-system-components-angular@1.0.1

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@2.0.2

## @swisspost/internet-header@1.13.6

### Patch Changes

- Added secure flag for cookies. (by
[@imagoiq](https://github.com/imagoiq) with
[#2629](#2629))

- Fixed display of internet-header icons on high-contrast mode with
light theme. (by [@imagoiq](https://github.com/imagoiq) with
[#2669](#2669))

- Fixed missing accessible labels on post-meta navigation links. (by
[@gfellerph](https://github.com/gfellerph) with
[#2700](#2700))

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.2

## @swisspost/design-system-intranet-header@5.0.9

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.2

## @swisspost/design-system-styles@6.6.2

### Patch Changes

- Updated high contrast styles for the form switch component. (by
[@alizedebray](https://github.com/alizedebray) with
[#2667](#2667))

- Fixed display of icons in high-contrast mode in webkit. (by
[@imagoiq](https://github.com/imagoiq) with
[#2638](#2638))

- Deprecated sizes `loader-sm` and `loader-xs` for the spinner. They are
replace respectively with `loader-40` and `loader-16`. (by
[@imagoiq](https://github.com/imagoiq) with
[#2612](#2612))

- Removed transparent background for notification in high-contrast mode.
(by [@imagoiq](https://github.com/imagoiq) with
[#2653](#2653))

- Fixed visibility of select arrow in icon in high-contrast mode with
light theme. (by [@imagoiq](https://github.com/imagoiq) with
[#2696](#2696))

- Sets the font-size of h5 on small mobile devices to 16px as defined in
Figma. (by [@gfellerph](https://github.com/gfellerph) with
[#2610](#2610))

## @swisspost/design-system-documentation@3.1.0

### Minor Changes

- Added contrast ratios agains black & white to color documentation. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#2376](#2376))

- Added override classes to the heading documentation and removed the
utitlites/headings, which was previouvly used to document the override
classes. (by [@b1aserlu](https://github.com/b1aserlu) with
[#2640](#2640))

- Added a documentation page for the post spinner component. (by
[@imagoiq](https://github.com/imagoiq) with
[#2612](#2612))

- Migrated documentation for card-button to storybook. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#2619](#2619))

### Patch Changes

- Fixed missing archive links in migrated page. (by
[@imagoiq](https://github.com/imagoiq) with
[#2663](#2663))

- Removed empty pages. (by [@imagoiq](https://github.com/imagoiq) with
[#2666](#2666))

- Documented `post-accordion-item` properties on Accordion page. (by
[@imagoiq](https://github.com/imagoiq) with
[#2630](#2630))

- Removed input type color variant as it is not compatible with the
current input styles. (by [@imagoiq](https://github.com/imagoiq) with
[#2628](#2628))

- Documented collapseChange event from post-accordion-item on
post-accordion. (by [@imagoiq](https://github.com/imagoiq) with
[#2620](#2620))

- Improved rendering of the home page for high-contrast mode. (by
[@imagoiq](https://github.com/imagoiq) with
[#2653](#2653))

-   Updated dependencies:
    -   @swisspost/design-system-icons@1.3.0
    -   @swisspost/design-system-styles@6.6.2
    -   @swisspost/internet-header@1.13.6
    -   @swisspost/design-system-components@2.0.2
    -   @swisspost/design-system-intranet-header@5.0.9
    -   @swisspost/design-system-components-angular@1.0.1
    -   @swisspost/design-system-components-react@1.0.28

## @swisspost/design-system-components-angular-workspace@1.0.2

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.2
    -   @swisspost/design-system-components@2.0.2

## @swisspost/design-system-components-react@1.0.28

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@2.0.2

## @swisspost/design-system-demo@7.2.2

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.2
    -   @swisspost/design-system-intranet-header@5.0.9

## @swisspost/design-system-intranet-header-workspace@3.0.9

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.2

## @swisspost/design-system-nextjs-integration@0.1.1

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.2
    -   @swisspost/internet-header@1.13.6
    -   @swisspost/design-system-components-react@1.0.28

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch approved these changes

@b1aserlu b1aserlu Awaiting requested review from b1aserlu

@davidritter-dotcom davidritter-dotcom Awaiting requested review from davidritter-dotcom

Assignees

@imagoiq imagoiq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add collapseChange event to post-accordion
3 participants
@imagoiq @swisspost-bot @oliverschuerch