Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): Close icon button is not visible on hover with HCM light #2705

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Feb 21, 2024

No description provided.

@imagoiq imagoiq self-assigned this Feb 21, 2024
@imagoiq imagoiq requested a review from a team as a code owner February 21, 2024 06:29
Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: e330e4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@imagoiq imagoiq linked an issue Feb 21, 2024 that may be closed by this pull request
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Feb 21, 2024

Preview environment ready: https://preview-2705--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2705--swisspost-design-system-next.netlify.app

@imagoiq imagoiq merged commit e7c2da6 into main Feb 29, 2024
9 checks passed
@imagoiq imagoiq deleted the fix/close-button-hcm-light-hover branch February 29, 2024 07:37
gfellerph pushed a commit that referenced this pull request Feb 29, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/design-system-components@2.0.3

### Patch Changes

- Improved display of tooltip arrow in high contrast mode. (by
[@imagoiq](https://github.com/imagoiq) with
[#2697](#2697))

- Fixes an issue with the post-popover component that stopped working
once trigger buttons were removed from the page or new trigger buttons
were added to the page asynchronously. (by
[@gfellerph](https://github.com/gfellerph) with
[#2695](#2695))

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.3

## @swisspost/design-system-components-angular@1.0.2

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@2.0.3

## @swisspost/internet-header@1.13.7

### Patch Changes

- Reinstated original navigation role for post-main-navigation. (by
[@imagoiq](https://github.com/imagoiq) with
[#2709](#2709))
-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.3

## @swisspost/design-system-intranet-header@5.0.10

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.3

## @swisspost/design-system-migrations@1.0.1

### Patch Changes

- Fixed missing migration files. (by
[@alizedebray](https://github.com/alizedebray) with
[#2712](#2712))

## @swisspost/design-system-styles@6.6.3

### Patch Changes

- Updated the color of success alerts from black to white for a better
contrast. (by [@alizedebray](https://github.com/alizedebray) with
[#2740](#2740))

- Fixed color-contrast on blockquote footer with dark background. (by
[@imagoiq](https://github.com/imagoiq) with
[#2714](#2714))

- Fixed close icon button which is not visible on hover with light theme
and high contrast mode enabled. (by
[@imagoiq](https://github.com/imagoiq) with
[#2705](#2705))

- Improved display of badge and switch checked state with high contrast
mode. (by [@imagoiq](https://github.com/imagoiq) with
[#2706](#2706))

- Reduced the `xxl` breakpoint size form 1441px to 1440ppx. (by
[@alizedebray](https://github.com/alizedebray) with
[#2741](#2741))

- Fixed color-contrast issue on valid form-feedback. (by
[@imagoiq](https://github.com/imagoiq) with
[#2717](#2717))

- Removes unwanted margin from heading within the notification overlay
component. (by [@b1aserlu](https://github.com/b1aserlu) with
[#2407](#2407))

## @swisspost/design-system-documentation@3.2.0

### Minor Changes

- Added a new documentation page about metadata. It has links to
documentations about most common metadata of a webpage as well as an
example of an HTML header. (by [@b1aserlu](https://github.com/b1aserlu)
with [#2511](#2511))

- Added a Button to the toolbar of Storybook to visit older versions of
the documentation. (by [@b1aserlu](https://github.com/b1aserlu) with
[#2635](#2635))

- Added a documentation page for the Subnavigation Component. (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#2574](#2574))

### Patch Changes

- Deprecated `rg` breakpoint. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2238](#2238))

- Removed the info banner telling everyone that the storybook docs are
in beta. They've grown up now. (by
[@gfellerph](https://github.com/gfellerph) with
[#2739](#2739))

- Added example for intranet-header component with
optionDropdownContent. (by [@imagoiq](https://github.com/imagoiq) with
[#2719](#2719))

- Added color value after color title to help for comparison. (by
[@imagoiq](https://github.com/imagoiq) with
[#2730](#2730))

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.3
    -   @swisspost/design-system-components@2.0.3
    -   @swisspost/internet-header@1.13.7
    -   @swisspost/design-system-intranet-header@5.0.10
    -   @swisspost/design-system-components-angular@1.0.2
    -   @swisspost/design-system-components-react@1.0.29

## @swisspost/design-system-components-angular-workspace@1.0.3

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.3
    -   @swisspost/design-system-components@2.0.3

## @swisspost/design-system-components-react@1.0.29

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-components@2.0.3

## @swisspost/design-system-demo@7.2.3

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.3
    -   @swisspost/design-system-intranet-header@5.0.10

## @swisspost/design-system-intranet-header-workspace@3.0.10

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.3

## @swisspost/design-system-nextjs-integration@0.1.2

### Patch Changes

-   Updated dependencies:
    -   @swisspost/design-system-styles@6.6.3
    -   @swisspost/internet-header@1.13.7
    -   @swisspost/design-system-components-react@1.0.29

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HCM Light: Toast close icon is not visible on hover
3 participants