fix(styles): Color-contrast on post-tabs with dark background #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d80c36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview environment ready: https://preview-2753--swisspost-web-frontend.netlify.app |
|
alizedebray
approved these changes
Mar 5, 2024
alizedebray
pushed a commit
that referenced
this pull request
Mar 5, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/design-system-components@2.1.0 ### Minor Changes - Added a new rating web-component. (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#2411](#2411)) ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.6.4 ## @swisspost/design-system-icons@1.4.0 ### Minor Changes - Added icons number 2576, 2577 and 2578. (by [@swisspost-bot](https://github.com/swisspost-bot) with [#2747](#2747)) ## @swisspost/design-system-components-angular@2.0.0 ### Patch Changes - Updated dependencies: - @swisspost/design-system-components@2.1.0 ## @swisspost/internet-header@1.13.8 ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.6.4 ## @swisspost/design-system-intranet-header@5.0.11 ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.6.4 ## @swisspost/design-system-migrations@1.0.2 ### Patch Changes - Fixed paths to the migration entry point. (by [@alizedebray](https://github.com/alizedebray) with [#2757](#2757)) ## @swisspost/design-system-styles@6.6.4 ### Patch Changes - Fixed color-contrast on post-tabs with dark background. (by [@imagoiq](https://github.com/imagoiq) with [#2753](#2753)) ## @swisspost/design-system-components-angular-workspace@1.0.4 ### Patch Changes - Updated dependencies: - @swisspost/design-system-components@2.1.0 - @swisspost/design-system-styles@6.6.4 ## @swisspost/design-system-components-react@1.0.30 ### Patch Changes - Updated dependencies: - @swisspost/design-system-components@2.1.0 ## @swisspost/design-system-demo@7.2.4 ### Patch Changes - Fixed broken links. (by [@alizedebray](https://github.com/alizedebray) with [#2756](#2756)) - Updated dependencies: - @swisspost/design-system-styles@6.6.4 - @swisspost/design-system-intranet-header@5.0.11 ## @swisspost/design-system-documentation@4.0.0 ### Patch Changes - Moved versions.json (used for version switcher) from archive to current documentation. (by [@imagoiq](https://github.com/imagoiq) with [#2748](#2748)) - Fixed broken links. (by [@alizedebray](https://github.com/alizedebray) with [#2756](#2756)) - Updated dependencies: - @swisspost/design-system-icons@1.4.0 - @swisspost/design-system-components@2.1.0 - @swisspost/design-system-styles@6.6.4 - @swisspost/design-system-components-angular@2.0.0 - @swisspost/design-system-components-react@1.0.30 - @swisspost/internet-header@1.13.8 - @swisspost/design-system-intranet-header@5.0.11 ## @swisspost/design-system-intranet-header-workspace@3.0.11 ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.6.4 ## @swisspost/design-system-nextjs-integration@0.1.3 ### Patch Changes - Updated dependencies: - @swisspost/design-system-styles@6.6.4 - @swisspost/design-system-components-react@1.0.30 - @swisspost/internet-header@1.13.8 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
To
Note: @rouvenpost @Cian77 I didn't implement what's in the design https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=70-18&mode=design&t=VxSxr2DejdjVc4mY-0 because it misses how it should look like on dark colored background and because we are quite limited at the moment with this
post-tabscomponent as the:host-contextselector is not available (and will never be it seems) on all browsers, so to adapt to a particular theme given by the parent, we can only use CSS custom properties (like--post-contrast-color-invertedor--post-contrast-color). That means the component doesn't know anything about the current theme. This is good if we want to go further on theme architecture where you only need to provide different variables to change a component, but we are not there yet. And finally, it is also complex to style for thepost-tabscomponent as well for thetabsHTML component, perhaps we should decouple those two.