feat!: rename everything #355

gfellerph · 2022-08-17T19:28:02Z

No description provided.

Freaking love to patch 4 packages at the same time.

…yles

…em-header-intranet

…em-components-angular

changeset-bot · 2022-08-17T19:28:05Z

🦋 Changeset detected

Latest commit: c2119aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@swisspost/design-system-demo	Major
@swisspost/design-system-styles	Major
@swisspost/design-system-intranet-header	Major
@swisspost/design-system-components-angular	Major
@swisspost/design-system-migrations	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-08-17T19:32:46Z

🚀 Preview environment ready: https://preview-355--swisspost-web-frontend.netlify.app

oliverschuerch · 2022-08-19T07:49:21Z

When running the script pnpm start:intranet-header, an error occurs in the File:
packages/components-angular/projects/intranet-header-showcase/src/app/app.module.ts line 4

// app.module.ts:4
import { SwissPostIntranetHeaderModule } from 'swisspost-intranet-header';

oliverschuerch · 2022-08-19T07:57:31Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-styles reset one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-styles@5.0.0-alpha.6 reset: `rimraf node_modules package-lock.json && npm run clean`
Exit status 1

oliverschuerch · 2022-08-19T08:06:36Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-styles lint one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-styles@5.0.0-alpha.6 lint: `stylelint src/**/*.scss`
Exit status 2

ℹ️ The script pnpm --filter design-system-styles lint:fix works fine.

oliverschuerch · 2022-08-19T08:30:34Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-styles storybook one after the other, many error occurs with the same info:

ERROR in ./src/post-basics.scss
Module build failed (from C:/GIT/swisspost/design-system/node_modules/.pnpm/style-loader@3.3.1/node_modules/style-loader/dist/cjs.js):
TypeError: this.getOptions is not a function
    at Object.loader (C:\GIT\swisspost\design-system\node_modules\.pnpm\style-loader@3.3.1\node_modules\style-loader\dist\index.js:19:24)
 @ ./.storybook/preview.js 1:0-33
 @ ./.storybook/preview.js-generated-config-entry.js
 @ multi C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+core-client@6.5.9_5f7f4oajfffdifcutnf2ilgsam/node_modules/@storybook/core-client/dist/esm/globals/polyfills.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+core-client@6.5.9_5f7f4oajfffdifcutnf2ilgsam/node_modules/@storybook/core-client/dist/esm/globals/globals.js C:/GIT/swisspost/design-system/node_modules/.pnpm/webpack-hot-middleware@2.25.1/node_modules/webpack-hot-middleware/client.js?reload=true&quiet=false&noInfo=true ./storybook-init-framework-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+html@6.5.9_@babel+core@7.18.10/node_modules/@storybook/html/dist/esm/client/preview/config-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+html@6.5.9_@babel+core@7.18.10/node_modules/@storybook/html/dist/esm/client/docs/config-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-links@6.5.9/node_modules/@storybook/addon-links/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-docs@6.5.9_@babel+core@7.18.10/node_modules/@storybook/addon-docs/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-actions@6.5.9/node_modules/@storybook/addon-actions/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-backgrounds@6.5.9/node_modules/@storybook/addon-backgrounds/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-measure@6.5.9/node_modules/@storybook/addon-measure/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-outline@6.5.9/node_modules/@storybook/addon-outline/preview.js-generated-config-entry.js C:/GIT/swisspost/design-system/node_modules/.pnpm/@storybook+addon-interactions@6.5.9/node_modules/@storybook/addon-interactions/preview.js-generated-config-entry.js ./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js

oliverschuerch · 2022-08-19T08:34:09Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-styles build:storybook one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-styles@5.0.0-alpha.6 build:storybook: `build-storybook`
Exit status 1

oliverschuerch · 2022-08-19T08:37:58Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo reset one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-demo@5.0.0-alpha.4 reset: `rimraf node_modules package-lock.json && npm run clean`
Exit status 1

gfellerph · 2022-08-19T08:43:47Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo reset one after the other, an error occurs:
ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-demo@5.0.0-alpha.4 reset: `rimraf node_modules package-lock.json && npm run clean`
Exit status 1

Removed the script as it's broken anyways and not needed anymore.

oliverschuerch · 2022-08-19T08:45:58Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo test one after the other, every single karma-test fails.
It is unclear whether this was already the case before the renamings?

gfellerph · 2022-08-19T08:49:06Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo test one after the other, every single karma-test fails. It is unclear whether this was already the case before the renamings?

Karma tests for all the packages are not set up

oliverschuerch · 2022-08-19T08:54:05Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo e2e one after the other, some errors occurs:

Jasmine started

  workspace-project App
    × should display welcome message
      - Expected 'Swiss Post' to equal 'Welcome to app!'.

**************************************************
*                    Failures                    *
**************************************************

1) workspace-project App should display welcome message
  - Expected 'Swiss Post' to equal 'Welcome to app!'.

Executed 1 of 1 spec (1 FAILED) in 2 secs.

oliverschuerch · 2022-08-19T08:54:41Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo e2e one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-demo@5.0.0-alpha.4 ng: `ng "e2e"`
Exit status 1

gfellerph · 2022-08-19T09:02:12Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-demo e2e one after the other, an error occurs:
ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-demo@5.0.0-alpha.4 ng: `ng "e2e"`
Exit status 1

e2e tests are not set up either

oliverschuerch · 2022-08-19T09:07:55Z

When running the scripts pnpm bootstrap and pnpm --filter design-system-components-angular clean one after the other, an error occurs:

ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @swisspost/design-system-components-angular@0.0.1-alpha.0 clean: `rimraf dist`
Exit status 1

sonarcloud · 2022-08-19T09:29:52Z

SonarCloud Quality Gate failed.

151 Bugs
0 Vulnerabilities
0 Security Hotspots
106 Code Smells

No Coverage information
1.7% Duplication

gfellerph added 8 commits August 17, 2022 20:24

chore: replace URLs

47d128c

chore: rename Common Web Frontend to Swiss Post Design System

6ca13e1

Freaking love to patch 4 packages at the same time.

chore: rename @swisspost/web-demo to @swisspost/design-system-demo

2d2c8f9

chore: replace @swisspost/web-styles with @swisspost/design-system-st…

f457bb4

…yles

chore: fix some remnant namings

b33400f

chore: replace @swisspost/intranet-header with @swisspost/design-syst…

cb68bfa

…em-header-intranet

chore: rename @swisspost/angular-components to @swisspost/design-syst…

3a29730

…em-components-angular

fix: revert publish config renaming which prevented successful build

eedd6b7

gfellerph linked an issue Aug 17, 2022 that may be closed by this pull request

Rename everything #354

Closed

13 tasks

gfellerph added 13 commits August 18, 2022 17:31

Merge branch 'main' into 354-rename-everything

1416c1c

chore: rename web-styles to styles

e2f27cb

chore: replace web-styles links with styles

2d1c3dd

chore: rename web-demo into demo

e511a2b

chore: rename paths from web-demo to demo

16cf1ca

chore: rename web-styles-migrations to migrations

12e3de5

chore: rename some remnant web-styles

8de6fce

chore: rename swisspost-intranet-header into header-intranet

c3eca1f

chore: remplace header paths

cb1ca92

chore: re-rename intranet-header

3399516

chore: rename angular-components to components-angular

f4d6d19

chore: rename angular-components to components-angular

4aea8fb

fix: address security hotspot

cf5edb0

gfellerph marked this pull request as ready for review August 18, 2022 19:48

gfellerph requested review from oliverschuerch and alizedebray August 18, 2022 19:51

gfellerph added 3 commits August 18, 2022 21:54

chore: add changeset

e3e1c6d

chore: rename some remaining cwf and web styles mentions

099e0b0

chore: update readme

f1fa269

gfellerph added 3 commits August 19, 2022 09:06

chore: replace CWF comments

062f6bf

chore: update link in readme

95a8f11

chore: update readme

55a949c

gfellerph added 3 commits August 19, 2022 10:25

fix: downgrade sass and style loader for webpack 4

fef0ae1

fix: slash division

0e22aad

fix: import header directly

f93ef4c

fix: remove broken reset script

f486b9d

gfellerph added 2 commits August 19, 2022 10:46

fix: add storybook dist to gitignore

034ad78

style: fix linting

f3b414b

fix: marked scripts that are not set up as todo

6c38774

fix: add rimraf to dev dependencies

c2119aa

oliverschuerch approved these changes Aug 19, 2022

View reviewed changes

gfellerph merged commit 256b9d8 into main Aug 19, 2022

gfellerph deleted the 354-rename-everything branch August 19, 2022 09:36

github-actions bot mentioned this pull request Aug 19, 2022

chore(changesets): 🦋📦 publish packages (alpha) #251

Merged

github-actions bot mentioned this pull request Nov 1, 2022

chore(changesets): 🦋📦 publish packages #671

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: rename everything #355

feat!: rename everything #355

gfellerph commented Aug 17, 2022

changeset-bot bot commented Aug 17, 2022 •

edited

github-actions bot commented Aug 17, 2022

oliverschuerch commented Aug 19, 2022 •

edited

oliverschuerch commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022 •

edited

oliverschuerch commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

gfellerph commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

gfellerph commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

gfellerph commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

sonarcloud bot commented Aug 19, 2022

feat!: rename everything #355

feat!: rename everything #355

Conversation

gfellerph commented Aug 17, 2022

changeset-bot bot commented Aug 17, 2022 • edited

🦋 Changeset detected

github-actions bot commented Aug 17, 2022

oliverschuerch commented Aug 19, 2022 • edited

oliverschuerch commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022 • edited

oliverschuerch commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

gfellerph commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

gfellerph commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

gfellerph commented Aug 19, 2022

oliverschuerch commented Aug 19, 2022

sonarcloud bot commented Aug 19, 2022

changeset-bot bot commented Aug 17, 2022 •

edited

oliverschuerch commented Aug 19, 2022 •

edited

oliverschuerch commented Aug 19, 2022 •

edited