fix(background): define correct colorvariables for light and black backgrounds #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ground-color-container
🦋 Changeset detectedLatest commit: 03f4f45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Preview environment ready: https://preview-357--swisspost-web-frontend.netlify.app |
oliverschuerch
changed the title
…ground-color-container # Conflicts: # packages/web-styles/src/placeholders/_notifications.scss
gfellerph
requested changes
Aug 18, 2022
...app/bootstrap/components/background/background-demo-page/background-demo-page.component.html
Show resolved
Hide resolved
...app/bootstrap/components/background/background-demo-page/background-demo-page.component.html
Show resolved
Hide resolved
…om background-utility
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
…ground-color-container # Conflicts: # packages/web-styles/src/components/badge.scss
|
Kudos, SonarCloud Quality Gate passed!
|
gfellerph
approved these changes
Aug 18, 2022
oliverschuerch
deleted the
fix/258-background-text-color-of-nested-background-color-container
branch
oliverschuerch
restored the
fix/258-background-text-color-of-nested-background-color-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the definition of bg-utility (bg-classes) was changed. If we have a light-background, the variable
--contrast-coloris defined as the best contrast color (in this case black). If we have a dark-background, it behaves the other way around (the--contrast-coloris white). The bg-classes were merged and optimized.Background-utilities are generated by us now. Bootstrap utilities were removed.
These changes made it easy to refactor the alerts/notifications components as well.
Currently not refactored (but possible) components are: Badges and Buttons.