Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles)!: rename index files for the styles #389

Merged
merged 10 commits into from
Aug 22, 2022
Merged

Conversation

gfellerph
Copy link
Member

@use '@swisspost/design-system-styles'; (Default internet styles)
@use '@swisspost/design-system-styles/intranet'; (Default intranet styles)
@use '@swisspost/design-system-styles/core' as post; (Variables, mixins, functions and placeholders)

  1. Default import is as simple as possible
  2. Intranet styles are clearly named as such
  3. Core functionality is a clear name, but for consistency with other prefixes, the core module can be namespaced as post. The usage would then be background-color: post.$yellow;

@gfellerph gfellerph linked an issue Aug 22, 2022 that may be closed by this pull request
2 tasks
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2022

🦋 Changeset detected

Latest commit: 5497821

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@swisspost/design-system-styles Major
@swisspost/design-system-demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

🚀 Preview environment ready: https://preview-389--swisspost-web-frontend.netlify.app

gfellerph and others added 8 commits August 22, 2022 15:54
Co-authored-by: Oliver Schürch <oli@skaos.ch>
Co-authored-by: Oliver Schürch <oli@skaos.ch>
Co-authored-by: Oliver Schürch <oli@skaos.ch>
Co-authored-by: Oliver Schürch <oli@skaos.ch>
Co-authored-by: Oliver Schürch <oli@skaos.ch>
The bootstrap license needs to be distributed with the CSS code according to https://getbootstrap.com/docs/5.2/about/license
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename _cwf.scss
2 participants