Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-file): Fix display errors on safari #433

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

oliverschuerch
Copy link
Contributor

I was able to eliminate almost all of the graphical errors.
Unfortunately this leads to the fact that you have to set the button translations via content CSS-property and these are dependent on the document-language.
The integrated languages are: en (default), de, fr, it

@oliverschuerch oliverschuerch linked an issue Aug 29, 2022 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022

🦋 Changeset detected

Latest commit: 8d3b45f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-styles Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

🚀 Preview environment ready: https://preview-433--swisspost-web-frontend.netlify.app

Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good workaround until we have the web component and I think it's ok to expect every document to have a html lang attribute.

@oliverschuerch oliverschuerch merged commit c8db73f into main Aug 29, 2022
@oliverschuerch oliverschuerch deleted the fix/266-form-file-safari-display-error branch August 29, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(form-file Safari): display error
2 participants