Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove cypress binary postinstallation from package files #656

Merged
merged 6 commits into from
Oct 31, 2022
Merged

fix: remove cypress binary postinstallation from package files #656

merged 6 commits into from
Oct 31, 2022

Conversation

oliverschuerch
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022 •
edited

🦋 Changeset detected

Latest commit: 18cf64a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-intranet-header Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 28, 2022 •
edited

Preview environment ready: https://preview-656--swisspost-design-system-components.netlify.app
Preview environment ready: https://preview-656--swisspost-web-frontend.netlify.app

@oliverschuerch oliverschuerch force-pushed the fix/remove-cypress-binary-postinstallation-from-package-files branch 26 times, most recently from cdbc3ed to 7b5c8c2 Compare October 31, 2022 07:49
@oliverschuerch oliverschuerch force-pushed the fix/remove-cypress-binary-postinstallation-from-package-files branch 10 times, most recently from ebb1616 to f2ee843 Compare October 31, 2022 08:45
@oliverschuerch oliverschuerch force-pushed the fix/remove-cypress-binary-postinstallation-from-package-files branch from f2ee843 to 41c8d89 Compare October 31, 2022 08:46
@oliverschuerch
Copy link
Contributor Author

Manually run the postintallation script on the cypress node_module did not work in github workflow.
I inserted an use_cache flag into the pnpm-setup action instead, to disable the cache in the test workflow only.

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oliverschuerch oliverschuerch merged commit 75d715c into main Oct 31, 2022
@oliverschuerch oliverschuerch deleted the fix/remove-cypress-binary-postinstallation-from-package-files branch October 31, 2022 10:29
This was referenced Oct 31, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliverschuerch @swisspost-bot @gfellerph