Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datatable): add styles and docs for loadingindicator #7

Merged
merged 7 commits into from
May 23, 2022

Conversation

Janobob
Copy link
Member

@Janobob Janobob commented Apr 5, 2022

  • feature(datatable): add styles and docs for loadingindicator

Feature has been requested by an employee of swiss post.

@Janobob Janobob added the enhancement New feature or request label Apr 5, 2022
@Janobob Janobob requested a review from gfellerph April 5, 2022 12:57
@Janobob Janobob self-assigned this Apr 5, 2022
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2022

🦋 Changeset detected

Latest commit: 9225f2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@swisspost/web-demo Patch
@swisspost/web-styles Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gfellerph
Copy link
Member

@Janobob, the datatable styles should match the other tables with a white seperator line between the rows:
image

@Janobob Janobob changed the title Feature Datatable Loadingindicator feature(datatable): add styles and docs for loadingindicator May 23, 2022
@Janobob Janobob changed the title feature(datatable): add styles and docs for loadingindicator feat(datatable): add styles and docs for loadingindicator May 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gfellerph gfellerph merged commit e0b1611 into main May 23, 2022
@gfellerph gfellerph deleted the feature/datatable-loadingIndicator branch May 23, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants