Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional monitoring metrics #14

Closed
mcweba opened this issue Apr 7, 2016 · 2 comments
Closed

Add additional monitoring metrics #14

mcweba opened this issue Apr 7, 2016 · 2 comments
Assignees

Comments

@mcweba
Copy link
Collaborator

mcweba commented Apr 7, 2016

For documentation and monitoring purposes, it would be useful to be able to extract information about the requests and their matching routing rule.

The request could be identfied by a configurable (system property) request header name. To identify the rule, an additional (unique) property called name could be added to each routing rule entry.

@lbovet
Copy link
Member

lbovet commented Apr 10, 2016

Is the name attribute now mandatory? This would break compatibility. Is there a way to keep it optional?

@mcweba
Copy link
Collaborator Author

mcweba commented Apr 11, 2016

I make the attribute optional and log a warning when the feature is activated and a rule without a name matches.

@mcweba mcweba closed this as completed in d8386db Apr 11, 2016
mcweba added a commit that referenced this issue Apr 12, 2016
roggerj pushed a commit to roggerj/gateleen that referenced this issue Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants