Update to Vertx 3.6.2 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Gateleen implements a few core Vertx interfaces for its "SelfClient" (i.e. "implements Http(Server|Client)(Request|Response)"). Those interfaces are often updated/extended from one Vertx-Version to the next one. It's always a mess to update the implementations with a bunch of "throw new UnsupportedOperationException(msg);" Therefor we now have interfaces (FastFailHttp....) with default-implementations (java 8 feature). This moves a lot of boiler plate code away from the main worker classes - Migrate some core classes from Vertx class CaseInsensitiveHeaders to VertxHttpHeaders. It's a 1:1 replacement and is a faster implementation (according to Vert.x Guru Julien Viet) - Due to a changed behaviour in HttpHeader when reading a 'single value' if 'multiple values are around' (see eclipse-vertx/vert.x#2688) we need to fix the "x-hooked" indicator in HookHandler: We now "set" and do not "add" to prevent multiple "x-hooked" in the Self-Request - A changed behaviour in "HttpServerRequest.ended" in Vertx 3.6 requires us to check 'isEnded' before we install an endHandler (in Gateleen's Forwarder)
Codecov Report
@@ Coverage Diff @@
## develop #264 +/- ##
=============================================
- Coverage 39.38% 39.26% -0.13%
+ Complexity 1195 1193 -2
=============================================
Files 175 177 +2
Lines 9575 9600 +25
Branches 997 998 +1
=============================================
- Hits 3771 3769 -2
- Misses 5465 5492 +27
Partials 339 339
Continue to review full report at Codecov.
|
hiddenalpha
approved these changes
Jan 21, 2019
ljucam
approved these changes
Jan 21, 2019
mcweba
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some implementation notes:
... implements Http(Server|Client)(Request|Response)).Those interfaces are often updated/extended from one Vertx-Version to the next one. It's always a mess to update the implementations with a bunch of "throw new UnsupportedOperationException(msg);"
Therefor we now have interfaces (
FastFailHttp....) with default-implementations (java 8 feature). This moves a lot of boiler plate code away from the main worker classesCaseInsensitiveHeaderstoVertxHttpHeaders. This is a simple 1:1 replacement and is a faster implementation (according to Vert.x Guru Julien Viet)Forwarder)