[SDCISA-13736, SDCISA-10974] Fix bad habits in HttpResourceStorage. #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #539 +/- ##
=============================================
- Coverage 47.70% 47.68% -0.02%
- Complexity 1784 1785 +1
=============================================
Files 225 225
Lines 11704 11713 +9
Branches 1227 1225 -2
=============================================
+ Hits 5583 5585 +2
- Misses 5634 5640 +6
- Partials 487 488 +1 ☔ View full report in Codecov by Sentry. |
hiddenalpha
requested review from
mcweba,
Kusig,
ljucam,
gateleen,
linovifian,
a team and
dominik-cnx
mcweba
requested changes
Jan 5, 2024
| log.warn("Failed request to {}: {}", path, asyncResult.cause()); | ||
| log.warn("Failed request to {}", path, new Exception("stacktrace", asyncResult.cause())); | ||
| log.error/*TODO*/("TODO why do we NOT report this error to bodyHandler?!? Is this" | ||
| + " maybe the reason for all our mysterious timeouts everywhere? (ERR_jGQCALsBAgBJeA)"); |
There was a problem hiding this comment.
We should not add logs for personal bug hunting to the codebase. Just build your own release locally and add the logs there.
| log.warn("Failed request to {}: {}", uri, asyncResult.cause()); | ||
| log.warn("Failed request to {}", uri, new Exception("stacktrace", asyncResult.cause())); | ||
| log.error/*TODO*/("TODO why do we not report this error to our caller?!? Is this maybe" | ||
| + " the explanation for all our unexplainable timeouts or lost messages we" |
There was a problem hiding this comment.
We should not add logs for personal bug hunting to the codebase. Just build your own release locally and add the logs there
mcweba
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.