[SDCISA-14715] Collect body only if needed #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Collect body only in-memory in those cases we really use it. - Fix sub-optimal logging statement. Related: - swisspost#417
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #559 +/- ##
=============================================
- Coverage 48.04% 47.67% -0.37%
+ Complexity 1850 1836 -14
=============================================
Files 232 232
Lines 11950 11956 +6
Branches 1260 1260
=============================================
- Hits 5741 5700 -41
- Misses 5713 5761 +48
+ Partials 496 495 -1 ☔ View full report in Codecov by Sentry. |
hiddenalpha
requested review from
mcweba,
Kusig,
ljucam,
gateleen,
Swisspusher,
linovifian and
a team
mcweba
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: