Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple locale support #4

Merged
merged 36 commits into from
Aug 16, 2023
Merged

Add multiple locale support #4

merged 36 commits into from
Aug 16, 2023

Conversation

swissspidy
Copy link
Owner

@swissspidy swissspidy commented Jun 22, 2023

To-do:

  • Demonstrate performance difference somehow, maybe using PHPBench?
  • More tests for edge cases

Fixes #3

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #4 (462e5df) into main (7fdd928) will increase coverage by 0.70%.
The diff coverage is 97.36%.

@@             Coverage Diff              @@
##               main       #4      +/-   ##
============================================
+ Coverage     91.13%   91.83%   +0.70%     
- Complexity      165      181      +16     
============================================
  Files             7        7              
  Lines           406      441      +35     
============================================
+ Hits            370      405      +35     
  Misses           36       36              
Flag Coverage Δ
default 91.83% <97.36%> (+0.70%) ⬆️
multisite 20.40% <15.78%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/class-ginger-mo.php 96.77% <96.82%> (-0.11%) ⬇️
...ib/class-ginger-mo-translation-compat-provider.php 91.42% <100.00%> (ø)
lib/class-ginger-mo-translation-compat.php 95.34% <100.00%> (+3.68%) ⬆️
lib/class-ginger-mo-translation-file.php 81.53% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@swissspidy
Copy link
Owner Author

swissspidy commented Jun 27, 2023

Performance Test Results

Performance test results for bdf1864 are in 🛎️!

WordPress Admin

Locale Scenario wp-memory-usage wp-total
en_US Default 15.71 MB 188.62 ms
de_DE Default 32.30 MB 248.90 ms
de_DE Ginger MO (MO) 20.34 MB 220.12 ms
de_DE Ginger MO (PHP) 17.32 MB 200.28 ms
de_DE Ginger MO (JSON) 20.33 MB 217.41 ms

Twenty Twenty-Three

Locale Scenario wp-memory-usage wp-total
en_US Default 14.85 MB 160.26 ms
de_DE Default 28.28 MB 213.62 ms
de_DE Ginger MO (MO) 18.30 MB 197.69 ms
de_DE Ginger MO (PHP) 16.02 MB 170.65 ms
de_DE Ginger MO (JSON) 18.29 MB 191.74 ms

Twenty Twenty-One

Locale Scenario wp-memory-usage wp-total
en_US Default 14.45 MB 145.49 ms
de_DE Default 27.94 MB 204.14 ms
de_DE Ginger MO (MO) 17.91 MB 176.65 ms
de_DE Ginger MO (PHP) 15.62 MB 152.68 ms
de_DE Ginger MO (JSON) 17.91 MB 172.07 ms

@swissspidy swissspidy marked this pull request as ready for review August 16, 2023 12:24
@swissspidy swissspidy merged commit 41b5b62 into main Aug 16, 2023
24 checks passed
@swissspidy swissspidy deleted the fix/2-multiple-locales branch August 16, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple locale support
1 participant