Add pcvSetVoltageEnabled and pcvGetVoltageEnabled #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting needs to match the other funcs. |
yellows8
reviewed
Nov 17, 2018
nx/source/services/pcv.c
Outdated
| ipcInitialize(&c); | ||
|
|
||
| struct { | ||
| u64 magic; |
There was a problem hiding this comment.
See other funcs whitespace.
yellows8
reviewed
Nov 17, 2018
nx/source/services/pcv.c
Outdated
| Result rc = serviceIpcDispatch(&g_pcvSrv); | ||
|
|
||
| if (R_SUCCEEDED(rc)) { | ||
| IpcParsedCommand r; |
There was a problem hiding this comment.
Use same whitespace as elsewhere.
yellows8
reviewed
Nov 18, 2018
nx/source/services/pcv.c
Outdated
| struct { | ||
| u64 magic; | ||
| u64 cmd_id; | ||
| bool state; |
yellows8
reviewed
Nov 18, 2018
nx/source/services/pcv.c
Outdated
| struct { | ||
| u64 magic; | ||
| u64 result; | ||
| bool isEnabled; |
yellows8
reviewed
Nov 18, 2018
nx/source/services/pcv.c
Outdated
| resp = r.Raw; | ||
|
|
||
| rc = resp->result; | ||
| *isEnabled = (bool)resp->isEnabled; |
There was a problem hiding this comment.
if (R_SUCCEEDED(rc) && isEnabled) ...
There was a problem hiding this comment.
Might want to do something similar with out_hz above too
yellows8
approved these changes
Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.