Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recoloured and added waves #8

Merged
merged 49 commits into from Feb 26, 2018
Merged

Recoloured and added waves #8

merged 49 commits into from Feb 26, 2018

Conversation

Adubbz
Copy link
Contributor

@Adubbz Adubbz commented Feb 20, 2018

This PR makes a few aesthetic improvements to the menu. Namely:

  • Added waves to the bottom of the screen (and re positioned elements accordingly)
  • Changed the background and text colour
  • Made the highlight around the active entry thicker

The new design can be seen in action here

And on actual hardware here (courtesy of VAL-001)

An alternate mode is also included, however it must be manually changed and compiled. It can be seen here

@Adubbz
Copy link
Contributor Author

Adubbz commented Feb 20, 2018

There was an issue with a single horizontal line of pixels underneath the icons not being filled in in the above images, that has been addressed now.

@plutooo
Copy link
Member

plutooo commented Feb 20, 2018

https://i.imgur.com/RkPrUYK.jpg

Make it look like this? :)

@jaames
Copy link
Contributor

jaames commented Feb 21, 2018

Plutoo mentioned that the intention was for hbl to match the switch theme, so here's a light variant of the same mockup:

https://i.imgur.com/X6C0SFU.jpg

Tomorrow I'll try to polish both of them a bit further

@Adubbz
Copy link
Contributor Author

Adubbz commented Feb 21, 2018

I updated it to be more in line with the concept art. See here

And for a screenshot of it running on hardware see: here

@CTCaer
Copy link

CTCaer commented Feb 21, 2018

@Adubbz
Great job!

Can you try the following small aesthetic changes:

  1. Remove the Name text border/fill (the rectangle on top of small icons).
  2. Name text left aligned to the start of white icon border (like Switch home menu game titles)
  3. Name text a little more higher (around the vertical center of the name text border).
  4. Dark directory text color.

It will look like this:

@Maufeat
Copy link
Contributor

Maufeat commented Feb 21, 2018

I like how it currently looks. Those changes above aren't looking ordered and clean. Should include "banner.jpg" for the top banner for each hbapp (bigger width than icon) everything else looks perfectly fine imo.

@jaames
Copy link
Contributor

jaames commented Feb 21, 2018

image

Since square icons are also being used for the large "details" view, I think it might look better if they're moved to the other side of the app title and description text

@MrKcyre
Copy link

MrKcyre commented Feb 21, 2018

wow nice job guys! this last concept looks perfect! the blue gradient in the wave detail is something awesome! And it looks super clean with the main text on the right side. nice job!

@jaames
Copy link
Contributor

jaames commented Feb 21, 2018

Thanks @MrKcyre!

Image assets and details on layout, colors, fonts, etc from my mockups can now be found here: https://github.com/jaames/switch-hbl-mockup :)

Also imo the waves are a little tall right now? I intended for the wave effect to be super subtle, with an amplitude of ~8px or so at the most, they feel a bit distracting otherwise

@yellows8
Copy link
Collaborator

Probably should wait to add time-display until local-time is supported, don't think most users want UTC.

@fincs
Copy link
Contributor

fincs commented Feb 21, 2018

This is kind of a silly nitpick, but there seems to be kind of an identity crisis in this project. The repository name is 'nx-hbmenu' but the program calls itself "The Homebrew Launcher" in current upstream. Having this be abbreviated to "hbl" in the redesign above reminded me of this. Can we do something about this? (Personally I've never liked the "hbl" abbreviation since it makes me think of HBlank - as a result I always call it 'hbmenu').
Also, it seems like "hbl" is also used to refer to the binary blob that actually implements the homebrew loading (i.e. not hbmenu); therefore calling hbmenu "hbl" adds to the confusion.

@Adubbz
Copy link
Contributor Author

Adubbz commented Feb 21, 2018

Made a few tweaks, the current state of the menu can be seen here

@jaames
Copy link
Contributor

jaames commented Feb 22, 2018

@fincs raises a good point imo. While I'm not particularly tied to either name, I thought it might be worth trying a mockup using a "hbmenu" logo for the sake of comparison:

@Adubbz
Copy link
Contributor Author

Adubbz commented Feb 22, 2018

I changed the name, upped the version number to 2.0.0 and hid the author and version for folders. I think it's good to go now. Preview

@plutooo
Copy link
Member

plutooo commented Feb 22, 2018

Looks sweet, can we get final comments from James

@plutooo
Copy link
Member

plutooo commented Feb 22, 2018

I think I can see a few nitpicks -- missing bold font on the logo, and lack of rounded corners

@plutooo
Copy link
Member

plutooo commented Feb 22, 2018

Let's do a full 2.0.0 release when jaames gives the approval. Awesome work so far

@Adubbz
Copy link
Contributor Author

Adubbz commented Feb 22, 2018

Yeah, fonts do indeed need changing but those are waiting on @fincs’s tool to be made public. I personally prefer non-rounded corners, plus they’re more in line with the real home menu. Will see what Jaames thinks

@plutooo
Copy link
Member

plutooo commented Feb 22, 2018

I feel like I'm asking for too much, but how about animation when moving sideways across the icons? Right now it's just instant lacking any smooth scrolling afaik?

@plutooo plutooo merged commit 114db71 into switchbrew:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet