-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Overseer #567
base: develop
Are you sure you want to change the base?
feat: Overseer #567
Conversation
26d5356
to
d56cb2d
Compare
Guess we're still waiting on baseurl support for this? |
Yup, not sure when that's coming... When it will, we're ready for it. |
@sadstan123456 did you install it? can you paste the logs specific to the installation? |
I'm so sorry. I misunderstood. I was unable to donate my comment
…On Sun, Feb 21, 2021 at 4:33 PM flying-sausages ***@***.***> wrote:
@sadstan123456 <https://github.com/sadstan123456> did you install it? can
you paste the logs specific to the installation?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#567 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASHBJHN7WCFPBQLURBHHJLDTADR63ANCNFSM4VQMOMSQ>
.
|
For those who intend to Beta test this:
You can run |
Development here: https://docs.overseerr.dev/extending-overseerr/reverse-proxy-examples location ^~ /overseerr {
set $app 'overseerr';
# Remove /overseerr path to pass to the app
rewrite ^/overseerr/?(.*)$ /$1 break;
proxy_pass http://127.0.0.1:5055; # NO TRAILING SLASH
# Redirect location headers
proxy_redirect ^ /$app;
proxy_redirect /setup /$app/setup;
proxy_redirect /login /$app/login;
# Sub filters to replace hardcoded paths
proxy_set_header Accept-Encoding "";
sub_filter_once off;
sub_filter_types *;
sub_filter 'href="/"' 'href="/$app"';
sub_filter 'href="/login"' 'href="/$app/login"';
sub_filter 'href:"/"' 'href:"/$app"';
sub_filter '/_next' '/$app/_next';
sub_filter '/api/v1' '/$app/api/v1';
sub_filter '/login/plex/loading' '/$app/login/plex/loading';
sub_filter '/images/' '/$app/images/';
sub_filter '/android-' '/$app/android-';
sub_filter '/apple-' '/$app/apple-';
sub_filter '/favicon' '/$app/favicon';
sub_filter '/logo.png' '/$app/logo.png';
sub_filter '/site.webmanifest' '/$app/site.webmanifest';
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been running this PR for about a month now without issue. Install was smooth, and upgrade function works without any errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using this PR for several months now on a Debian 9 server, without any issues. Upgrading to new versions works flawlessly, and the stock nginx template worked right out of the box.
Heya, this PR is on hold until Overseerr has proper baseurl support. At the current time of writing, if you were to be on a page inside Overseerr and reload the page it will go to a null route. This is why there is an “external blocking dependency” tag on the PR. Thanks for the feedback though. Muchly appreciated ;) /b |
Totally understand this branch isn't ready until Overseerr adds base url support, but just wanted to let you know @brettpetch that it looks like the server no longer boots up after installing. I checked port 5055 and nothing was there. Before the force push it was working, so maybe something changed |
Hey thx for the report. I’ll look at it later today.
/b
… On Sep 28, 2021, at 4:41 AM, Joseph Théberge ***@***.***> wrote:
Totally understand this branch isn't ready until Overseerr adds base url support, but just wanted to let you know @brettpetch that it looks like the server no longer boots up after installing. I checked port 5055 and nothing was there. Before the force push it was working, so maybe something changed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This comment has been minimized.
This comment has been minimized.
Going to link this to sct/overseerr#274 and sct/overseerr#2383 |
How is it going? Have they added base url support yet? |
No. You can review the linked issue above and follow this on their own issue tracker. |
Fixes issues:
Proposed Changes:
Categories
Architectures
x86_64
is specifically handled as: Successarm64
is specifically handled as: SuccessChecklist
Testing done
OS & Version: Ubuntu for arm 20.04
How have you tested this
Scenarios tested:
Other remarks
Still needs baseurl support, partially blocked by sct/overseerr#274 (no need for pre-run-time, as we can just always build it with the
/overseerr
baseurl regardless of nginx)