Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Overseer #567

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

feat: Overseer #567

wants to merge 16 commits into from

Conversation

flying-sausages
Copy link
Member

@flying-sausages flying-sausages commented Jan 1, 2021

Fixes issues:

Proposed Changes:

  • Overseerr install script

Categories

  • New feature (non-breaking change which adds functionality)

Architectures

  • x86_64 is specifically handled as: Success
    • Notes: Allegedly uns fine from what I heard
  • arm64 is specifically handled as: Success

Checklist

Testing done

OS & Version: Ubuntu for arm 20.04

How have you tested this

Scenarios tested:

  • Installed without nginx

Other remarks

Still needs baseurl support, partially blocked by sct/overseerr#274 (no need for pre-run-time, as we can just always build it with the /overseerr baseurl regardless of nginx)

@liaralabs
Copy link
Member

Guess we're still waiting on baseurl support for this?

@flying-sausages
Copy link
Member Author

Guess we're still waiting on baseurl support for this?

Yup, not sure when that's coming... When it will, we're ready for it.

@flying-sausages
Copy link
Member Author

@sadstan123456 did you install it? can you paste the logs specific to the installation?

@sadstan
Copy link

sadstan commented Feb 21, 2021 via email

@flying-sausages
Copy link
Member Author

For those who intend to Beta test this:

  • Read the beta testing instructions
  • git checkout overseer (yes I know I misspelled the branch name)
  • box install overseer
  • Access Overseer using your IP on port 5055 (domain might not work if you're using SSL due to HSTS security)

You can run box update to go back on the master branch without any lasting effects on the rest of your installation

@brettpetch
Copy link
Member

brettpetch commented Mar 22, 2021

For those who intend to Beta test this:

* [Read the beta testing instructions](https://swizzin.ltd/dev/beta-testing)

* `git checkout overseer` (yes I know I misspelled the branch name)

* `box install overseer`

* Access Overseer using your IP on port `5055` (domain might not work if you're using SSL due to HSTS security)

You can run box update to go back on the master branch without any lasting effects on the rest of your installation

Development here: https://docs.overseerr.dev/extending-overseerr/reverse-proxy-examples

location ^~ /overseerr {
    set $app 'overseerr';
    # Remove /overseerr path to pass to the app
    rewrite ^/overseerr/?(.*)$ /$1 break;
    proxy_pass http://127.0.0.1:5055;  # NO TRAILING SLASH
    # Redirect location headers
    proxy_redirect ^ /$app;
    proxy_redirect /setup /$app/setup;
    proxy_redirect /login /$app/login;
    # Sub filters to replace hardcoded paths
    proxy_set_header Accept-Encoding "";
    sub_filter_once off;
    sub_filter_types *;
    sub_filter 'href="/"' 'href="/$app"';
    sub_filter 'href="/login"' 'href="/$app/login"';
    sub_filter 'href:"/"' 'href:"/$app"';
    sub_filter '/_next' '/$app/_next';
    sub_filter '/api/v1' '/$app/api/v1';
    sub_filter '/login/plex/loading' '/$app/login/plex/loading';
    sub_filter '/images/' '/$app/images/';
    sub_filter '/android-' '/$app/android-';
    sub_filter '/apple-' '/$app/apple-';
    sub_filter '/favicon' '/$app/favicon';
    sub_filter '/logo.png' '/$app/logo.png';
    sub_filter '/site.webmanifest' '/$app/site.webmanifest';
}

@flying-sausages flying-sausages changed the title APP: Overseer feat: Overseer Apr 27, 2021
@flying-sausages
Copy link
Member Author

Copy link

@ohmybahgosh ohmybahgosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been running this PR for about a month now without issue. Install was smooth, and upgrade function works without any errors.

@flying-sausages flying-sausages changed the base branch from master to develop May 27, 2021 21:16
Copy link

@ohmybahgosh ohmybahgosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this PR for several months now on a Debian 9 server, without any issues. Upgrading to new versions works flawlessly, and the stock nginx template worked right out of the box.

@brettpetch
Copy link
Member

I've been using this PR for several months now on a Debian 9 server, without any issues. Upgrading to new versions works flawlessly, and the stock nginx template worked right out of the box.

Heya, this PR is on hold until Overseerr has proper baseurl support. At the current time of writing, if you were to be on a page inside Overseerr and reload the page it will go to a null route. This is why there is an “external blocking dependency” tag on the PR.

Thanks for the feedback though. Muchly appreciated ;)

/b

@jtheberge
Copy link

Totally understand this branch isn't ready until Overseerr adds base url support, but just wanted to let you know @brettpetch that it looks like the server no longer boots up after installing. I checked port 5055 and nothing was there. Before the force push it was working, so maybe something changed

@brettpetch
Copy link
Member

brettpetch commented Sep 28, 2021 via email

@dennisoderwald

This comment has been minimized.

@brettpetch
Copy link
Member

brettpetch commented Feb 13, 2022

Going to link this to sct/overseerr#274 and sct/overseerr#2383

@blixten85
Copy link

How is it going? Have they added base url support yet?

@liaralabs
Copy link
Member

No. You can review the linked issue above and follow this on their own issue tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants