-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to run under subpath/basepath #2383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good 👍🏻
Also, have you tested to verify the service worker still functions as expected when a base path is configured? |
I completely missed the service worker sorry. (was completely borked. wouldnt register either) |
7d3a4b0
to
31bc931
Compare
I wonder if a wrapper for |
Oh do you mean like a useRouter wrapper link the wrapper. Should be possible sure. |
31bc931
to
252ac5b
Compare
This comment has been minimized.
This comment has been minimized.
252ac5b
to
6b6d520
Compare
14139df
to
63e4b0e
Compare
717af6b
to
abef384
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@megamit @TheCatLady Is there anything left to be done on this? Happy to help if you let me know what's remaining to get this merged. |
@coder8338 This got stuck as i couldnt do this cleanly without messing with next.js internals using the approach i took. Most likely you would need to start from scratch on a different approach. |
Hi! Would I be correct that this topic is about the same thing? Especially this topic (3 days old now) is about what we'd need for this to happen (if I understood it correctly) |
@crashkonijn Yep that's exactly it |
Description
Can now pass in the BASE_PATH environment variable to tell overseerr to host under a sub path.
e.g. BASE_PATH=/request_some_stuff would run as example.com/request_some_stuff/
To-Dos
yarn build
Issues Fixed or Closed