Add "See also" links #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds dotenv and sqlite to dependencies.
Adds a new table `link` that keeps track of links between bindings. Currently the only link is "See also", but this in future be extended to keep track of different types of links (such as 'deprecated by' or 'alias for'). The entries for the new table are created via a list in `seed.janet`.
pepe
approved these changes
Dec 10, 2020
|
I don't think the semicolons will affect anything, but yeah this does look good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new table
linkthat keeps track of links between bindings.Links are displayed under "See also" above the user contributed examples.
In future be extended to keep track of different types of links (such as 'deprecated by' or
'alias for'). This is why it has the relative generic name links.
The entries for the new table are created via a list in
seed.janet.More entries should be created in the future...
I also added semicolons to
schema.sqlin order to be able to dosqlite new.db < db/schema.sql.Was not sure whether this conflicts with any other tooling...
And the PR includes also some small changes to the
project.janet. I added dependencies that I needed to get it to run and a I updated the license and author field. These changes are independent of the "see also" change and if you prefer I can leave them out of this PR.