get pcid by a random cid #2669
Merged
get pcid by a random cid #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twose
requested changes
Jul 9, 2019
twose
requested changes
Jul 9, 2019
twose
approved these changes
Jul 9, 2019
twose
requested changes
Jul 9, 2019
twose
requested changes
Jul 9, 2019
twose
approved these changes
Jul 9, 2019
twose
requested changes
Jul 9, 2019
There was a problem hiding this comment.
swoole-src/swoole_coroutine.cc
Line 188 in 5ec8b07
arginfo_swoole_coroutine_getPcid
忘记修改参数了，编译的时候竟然没有报错。估计和这个参数是可选的有关？ |
arginfo是static的, 如果没有用到会有unused警告, 和编译器及其错误级别有关 |
twose
requested changes
Jul 10, 2019
twose
requested changes
Jul 10, 2019
twose
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2668