Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support native-curl hook #3863

Merged
merged 57 commits into from
Nov 28, 2020
Merged

Support native-curl hook #3863

merged 57 commits into from
Nov 28, 2020

Conversation

matyhtf
Copy link
Member

@matyhtf matyhtf commented Nov 20, 2020

No description provided.

twose
twose requested changes Nov 20, 2020
View reviewed changes
examples/curl/hook.php Outdated Show resolved Hide resolved
examples/curl/server.php Outdated Show resolved Hide resolved
ext-src/php_swoole.h Show resolved Hide resolved
thirdparty/php/curl/php_curl.h Outdated Show resolved Hide resolved
ext-src/swoole_runtime.cc Outdated Show resolved Hide resolved
ext-src/php_swoole_coroutine.h Show resolved Hide resolved
@twose
Copy link
Member

twose commented Nov 20, 2020

是否可以将原先的单测套上循环, 在native模式下再测一次

@matyhtf matyhtf changed the title Support curl-native hook Support native-curl hook Nov 21, 2020
@matyhtf
Copy link
Member Author

matyhtf commented Nov 24, 2020 •
edited
Loading

是否可以将原先的单测套上循环, 在native模式下再测一次

不需要，native curl client 大部分逻辑是 curl 完成的，所有选项参数和API的逻辑正确性应该由 libcurl库保证。我们这里的单测应该重新写，覆盖到 interface.cc 本身的关键逻辑。

@matyhtf matyhtf closed this Nov 24, 2020
@matyhtf matyhtf reopened this Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020 •
edited
Loading

Codecov Report

Merging #3863 (c3ca0b0) into master (6a2cafd) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3863      +/-   ##
==========================================
- Coverage   49.04%   49.01%   -0.03%     
==========================================
  Files          69       69              
  Lines       12858    12859       +1     
==========================================
- Hits         6306     6303       -3     
- Misses       6552     6556       +4
Impacted Files Coverage Δ
src/reactor/base.cc 60.00% <0.00%> (-1.26%) ⬇️
src/reactor/epoll.cc 75.23% <0.00%> (ø)
src/core/base.cc 75.56% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2cafd...c3ca0b0. Read the comment docs.

@matyhtf matyhtf merged commit 3d2def0 into master Nov 28, 2020
@matyhtf matyhtf deleted the curl-native branch November 29, 2020 13:30
@TheNorthMemory TheNorthMemory mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twose twose twose requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matyhtf @twose @huanghantao