Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Lost onclose event #4204

Merged
merged 2 commits into from
May 13, 2021
Merged

fix Lost onclose event #4204

merged 2 commits into from
May 13, 2021

Conversation

matyhtf
Copy link
Member

@matyhtf matyhtf commented May 12, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #4204 (d8a0545) into master (6797e68) will increase coverage by 0.09%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4204      +/-   ##
==========================================
+ Coverage   50.11%   50.20%   +0.09%     
==========================================
  Files          71       71              
  Lines       14266    14263       -3     
==========================================
+ Hits         7149     7161      +12     
+ Misses       7117     7102      -15     
Impacted Files Coverage Δ
src/os/signal.cc 73.61% <ø> (ø)
src/reactor/epoll.cc 75.23% <ø> (ø)
src/reactor/base.cc 74.55% <50.00%> (+0.77%) ⬆️
src/server/reactor_thread.cc 56.09% <50.00%> (-0.16%) ⬇️
src/server/master.cc 54.07% <100.00%> (+0.10%) ⬆️
src/os/wait.cc 74.11% <0.00%> (-7.06%) ⬇️
src/os/msg_queue.cc 57.62% <0.00%> (-3.39%) ⬇️
src/coroutine/socket.cc 39.44% <0.00%> (+0.47%) ⬆️
src/os/async_thread.cc 69.73% <0.00%> (+0.87%) ⬆️
src/protocol/base.cc 63.15% <0.00%> (+1.97%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6797e68...d8a0545. Read the comment docs.

@matyhtf matyhtf merged commit b1d1833 into master May 13, 2021
@sy-records sy-records deleted the fix-bug-lost-onclose-event branch May 13, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant