Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for mail headers in Mailgun adapter #134

Merged
merged 2 commits into from
May 30, 2017
Merged

Support for mail headers in Mailgun adapter #134

merged 2 commits into from
May 30, 2017

Conversation

bhserna
Copy link
Contributor

@bhserna bhserna commented May 30, 2017

This pull request adds support for mail headers in the Mailgun adapter, sending the headers added with the function Email.header/3 according with the Mailgun documentation (https://documentation.mailgun.com/api-sending.html#sending)

h:X-My-Header h: prefix followed by an arbitrary value allows to append a custom MIME header to the message (X-My-Header in this case). For example, h:Reply-To to specify Reply-To address.

princemaple
princemaple approved these changes May 30, 2017
View reviewed changes
Copy link
Member

@princemaple princemaple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@princemaple princemaple merged commit 73d04ff into swoosh:master May 30, 2017
@princemaple
Copy link
Member

Thanks @bhserna !

@bhserna
Copy link
Contributor Author

bhserna commented May 31, 2017

@princemaple Thank you for fix it and merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@princemaple princemaple princemaple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhserna @princemaple