Add dkim support to smtp adapter

[nicksanders]

dkim config can be added to config or email.provider_options or both, dkim config in email.provider_options overrides the one in the config.

[stevedomin]

@nicksanders do you have a use-case for overriding the DKIM options on the per-email basis? If not I'd be quite keen on keeping it simple for now.

[nicksanders]

@stevedomin That's fine, I wanted the ability to use different dkim configs depending on the sender domain but I can update the config on deliver. I have also added dkim support to sendmail.

[stevedomin]

Thank you so much @nicksanders!!

As a heads up, I might end up extracting the common functionalities from SMTP and Sendmail in a separate module. Haven't figured out where it should live yet.

[nicksanders]

Yeah, I had thought that as well, something like RawEmail
On 3 May 2016 12:26 p.m., "Steve Domin" notifications@github.com wrote:

Thank you so much @nicksanders https://github.com/nicksanders!!

As a heads up, I might end up extracting the common functionalities from
SMTP and Sendmail in a separate module. Haven't figured out where it should
live yet.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#74 (comment)

[barisbalic]

👍 on the extraction, documenting my opinion even though we've talked about it :D