Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpsd_client: Please set frame_id #7

Closed
nxdefiant opened this issue Aug 7, 2017 · 3 comments
Closed

gpsd_client: Please set frame_id #7

nxdefiant opened this issue Aug 7, 2017 · 3 comments
Assignees
@kriskozak
Labels
enhancement

Comments

@nxdefiant
Copy link

nxdefiant commented Aug 7, 2017 •
edited
Loading

The frame_id is currently not set but is required for use with e.g. robot_localization. So please allow to set the frame_id by parameter or just default to "gps".
@nxdefiant nxdefiant changed the title gpsd_client: Please allow to set frame_id gpsd_client: Please set frame_id Aug 7, 2017
@kriskozak
Copy link

I needed a brief distraction, so I addressed this issue on 7-set-frame-id (https://github.com/swri-robotics/gps_umd/tree/7-set-frame-id). @pjreed, please have a look.

@nxdefiant
Copy link
Author

Awesome, btw I forgot that I already created this issue in ros-drivers#6 a few month ago.

@pjreed
Copy link

pjreed commented Aug 8, 2017

Looks good to me. Want to make a PR for it?

@pjreed pjreed mentioned this issue Aug 8, 2017
Merged
@pjreed pjreed closed this as completed in #8 Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriskozak kriskozak

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nxdefiant @kriskozak @pjreed