Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for tile_map_plugin.cpp:411:31: error: ‘trim_copy’ is not a member of ‘boost’ #497

Merged

Conversation

AustinDeric
Copy link
Contributor

Added #include <boost/algorithm/string/trim.hpp> to tile_map_plugin.h to fix the error:

/mapviz/tile_map/src/tile_map_plugin.cpp:408:31: error: ‘trim_copy’ is not a member of ‘boost’
                YAML::Value << boost::trim_copy(bing_source->GetApiKey().toStdString());
                               ^
/mapviz/tile_map/src/tile_map_plugin.cpp:411:31: error: ‘trim_copy’ is not a member of ‘boost’
                YAML::Value << boost::trim_copy(ui_.source_combo->currentText().toStdString());
                               ^
make[2]: *** [CMakeFiles/tile_map_plugin.dir/src/tile_map_plugin.cpp.o] Error 1
make[1]: *** [CMakeFiles/tile_map_plugin.dir/all] Error 2
make: *** [all] Error 2

Its not clear to me why the travisci is not failing on this.

…p:408:31: error: ‘trim_copy’ is not a member of ‘boost’
@evenator
Copy link
Contributor

evenator commented Aug 3, 2017

LGTM.

@AustinDeric
Copy link
Contributor Author

@evenator More concerning is why travis is not failing when building this package. Any insight as to why its passing? Maybe open an issue against that?

@pjreed
Copy link
Contributor

pjreed commented Aug 3, 2017

I haven't dug into it, but I suspect that travis is building the entire repository at once rather than each package in isolation, and that dependency may be getting included due to another package.

@evenator
Copy link
Contributor

evenator commented Aug 3, 2017

I haven't dug into it, but I suspect that travis is building the entire repository at once rather than each package in isolation, and that dependency may be getting included due to another package.

It shouldn't be--it's using catkin_tools for the build.

@evenator evenator merged commit 6d7ff67 into swri-robotics:kinetic-devel Aug 3, 2017
@evenator
Copy link
Contributor

evenator commented Aug 3, 2017

I'm most confused that an error introduced about a year ago is only cropping up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants