Added "keep image ratio" to Image plugin #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malban
pushed a commit
to malban/mapviz
that referenced
this pull request
Nov 17, 2017
malban
pushed a commit
that referenced
this pull request
Nov 17, 2017
|
Does anyone at SWRI ever say "thanks for contributing"? |
|
Some of us do at least: #539 (comment) #525 (comment) But regardless, thanks for contributing, we appreciate it and are glad you find the tool useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I believe this PR would help making the Image Plugin more usable.
Added "Keep original image ratio" to the Widget. When checked, the height is automatically adjust, both in "percent" and "pixel" mode. The user should only modify the Width whilst the Height is updated accordingly.
When changing the mode from "percent" to "pixel" and vice versa, the image size is preserved.
To be sure that no resize is introduced in step 2), I had to change the width and height type and QSpinBox to double and QDoubleSpinBox, and percend must have 1 decimal.
Cheers