Fix issue with loading Bing map tiles #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bing API requires making an initial authorization call before it can generate URLs for requesting tiles. A side effect of this was that if the tile_map plugin tried to request any times before that initial call completed, those tiles would fail to load, and they would *never* load properly after that. This adds a mechanism for the tile source to indicate whether it is ready to load tiles or not, and the tile_map plugin will wait until it is ready before requesting images, so Bing maps should always load properly on startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bing API requires making an initial authorization call before it can
generate URLs for requesting tiles. A side effect of this was that if
the tile_map plugin tried to request any times before that initial call
completed, those tiles would fail to load, and they would never load
properly after that.
This adds a mechanism for the tile source to indicate whether it is
ready to load tiles or not, and the tile_map plugin will wait until it
is ready before requesting images, so Bing maps should always load
properly on startup.