Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Messages For Autodocumentation #113

Merged
merged 4 commits into from Sep 2, 2021
Merged

Add Messages For Autodocumentation #113

merged 4 commits into from Sep 2, 2021

Conversation

matt-attack
Copy link
Contributor

No description provided.

@matt-attack
Copy link
Contributor Author

@daniel-dsouza

@danthony06
Copy link
Collaborator

I like the idea, but I think we should put them in a separate package within marti_messages, like marti_messages/marti_introspection_msgs or something like that. The common messages are stamped versions of primitive types, so it's not the first place I would expect messages like this to go.

@matt-attack
Copy link
Contributor Author

Works for me. Wasn't sure if it involved too much work to do that.

@matt-attack
Copy link
Contributor Author

Updated to be in separate package.

@danthony06 danthony06 merged commit 01f5a81 into swri-robotics:master Sep 2, 2021
@matt-attack matt-attack deleted the add-autodoc branch September 2, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danthony06 danthony06 danthony06 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matt-attack @danthony06