Add support for BESTXYZ topic #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to add unit tests to this, but first I want to know if there are any special requirements for the .pcap files used in the existing test cases. |
|
Added unit test to parser_tests.cpp |
|
@pjreed The travis build passed, but it looks like github hasn't updated the check indicator. Any idea why? |
|
No special requirements on the pcap files, but thanks for adding that. I think that's also just a glitch with GitHub or Travis, it seems like sometimes the status indicator doesn't update after a build is done... |
msmcconnell
referenced
this pull request
in usdot-fhwa-stol/novatel_gps_driver
Jun 7, 2019
Add support for BESTXYZ topic (#42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NovATel OEM7 specification includes a BESTXYZ message which reports the location of the vehicle in an ECEF frame. This PR adds support for this message type by adding a NovatelXYZ.msg file and the associated parser (bestxyz.h/.cpp). The messages are published to the /bestxyz topic. This was tested on a NovATel PwrPak7.
The BESTXYZ message spec
https://docs.novatel.com/OEM7/Content/Logs/BESTXYZ.htm?tocpath=Logs%7CView%20Logs%7CGNSS%20Logs%7C_____18